migrate httpClient to okhttp in the currency plugin (#108)

Author: spolti

rebot-plugins/rebot-brazil-postalcode-plugin/pom.xml

@@ -99,6 +99,9 @@
         <groupId>io.quarkus</groupId>
         <artifactId>quarkus-maven-plugin</artifactId>
         <version>${io.quarkus.version}</version>
+        <configuration>
+          <noDeps>true</noDeps>
+        </configuration>
         <executions>
           <execution>
             <goals>

rebot-plugins/rebot-currency-plugin/pom.xml

@@ -74,8 +74,8 @@
     </dependency>
 
     <dependency>
-      <groupId>org.apache.httpcomponents</groupId>
-      <artifactId>httpclient</artifactId>
+      <groupId>com.squareup.okhttp3</groupId>
+      <artifactId>okhttp</artifactId>
     </dependency>
 
     <dependency>

rebot-plugins/rebot-currency-plugin/src/main/java/xyz/rebasing/rebot/plugin/currency/ecb/ECBClient.java

@@ -23,6 +23,7 @@
 
 package xyz.rebasing.rebot.plugin.currency.ecb;
 
+import java.io.InputStream;
 import java.lang.invoke.MethodHandles;
 
 import javax.enterprise.context.ApplicationScoped;
@@ -33,12 +34,9 @@
 import com.github.benmanes.caffeine.cache.Cache;
 import com.github.benmanes.caffeine.cache.Caffeine;
 import io.quarkus.scheduler.Scheduled;
-import org.apache.http.HttpResponse;
-import org.apache.http.client.config.CookieSpecs;
-import org.apache.http.client.config.RequestConfig;
-import org.apache.http.client.methods.HttpGet;
-import org.apache.http.impl.client.CloseableHttpClient;
-import org.apache.http.impl.client.HttpClients;
+import okhttp3.OkHttpClient;
+import okhttp3.Request;
+import okhttp3.Response;
 import org.jboss.logging.Logger;
 import xyz.rebasing.rebot.service.persistence.repository.EcbRepository;
 
@@ -63,35 +61,39 @@ public Cache<String, Object> cache() {
 
     @Scheduled(every = "12h", delay = 60)
     public void getAndPersistDailyCurrencies() {
-        try {
+        OkHttpClient client = new OkHttpClient.Builder()
+                .build();
+        Request request = new Request.Builder()
+                .url(ECB_XML_ADDRESS)
+                .get()
+                .build();
+
+        try (Response response = client.newCall(request).execute()) {
             log.debugv("Parsing currencies from {0}", ECB_XML_ADDRESS);
 
             SAXParserFactory saxParser = SAXParserFactory.newInstance();
             saxParser.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true);
             saxParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", true);
 
-            HttpGet httpReq = new HttpGet(ECB_XML_ADDRESS);
-            HttpResponse response = client().execute(httpReq);
-
-            saxParser.newSAXParser().parse(response.getEntity().getContent(), handler);
+            try (InputStream input = response.body().byteStream()) {
+                if (input != null) {
+                    saxParser.newSAXParser().parse(response.body().byteStream(), handler);
+                } else {
+                    throw new NullPointerException("Response is null");
+                }
+            }
 
             repository.persist(handler.cubes());
             c.cleanUp();
             handler.cubes().getCubes().forEach(cube -> {
                 c.put(cube.getCurrency(), cube);
                 c.put("time", handler.cubes().getTime());
             });
+
         } catch (final Exception e) {
             log.errorv("Error to retrieve currency rates from {0} - message: {1}", ECB_XML_ADDRESS, e.getMessage());
         } finally {
             handler.clean();
         }
     }
-
-    private CloseableHttpClient client() {
-        RequestConfig config = RequestConfig.custom()
-                .setCookieSpec(CookieSpecs.IGNORE_COOKIES)
-                .build();
-        return HttpClients.custom().setDefaultRequestConfig(config).build();
-    }
 }

rebot-plugins/rebot-currency-plugin/src/test/java/xyz/rebasing/rebot/plugin/currency/test/SaxParserTest.java

@@ -1,7 +1,7 @@
 /*
  *   The MIT License (MIT)
  *
- *   Copyright (c) 2017 Rebasing.xyz ReBot 
+ *   Copyright (c) 2017 Rebasing.xyz ReBot
  *
  *   Permission is hereby granted, free of charge, to any person obtaining a copy of
  *   this software and associated documentation files (the "Software"), to deal in
@@ -29,12 +29,9 @@
 import javax.xml.parsers.SAXParser;
 import javax.xml.parsers.SAXParserFactory;
 
-import org.apache.http.HttpResponse;
-import org.apache.http.client.config.CookieSpecs;
-import org.apache.http.client.config.RequestConfig;
-import org.apache.http.client.methods.HttpGet;
-import org.apache.http.impl.client.CloseableHttpClient;
-import org.apache.http.impl.client.HttpClients;
+import okhttp3.OkHttpClient;
+import okhttp3.Request;
+import okhttp3.Response;
 import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Ignore;
@@ -47,15 +44,19 @@
 public class SaxParserTest {
 
     public static final String ECB_XML_ADDRESS = "http://www.ecb.europa.eu/stats/eurofxref/eurofxref-daily.xml";
-
     private EcbSaxHandler handler = new EcbSaxHandler();
 
     @Before
     public void populateCubes() throws ParserConfigurationException, SAXException, IOException {
         SAXParser saxParser = SAXParserFactory.newInstance().newSAXParser();
-        HttpGet httpReq = new HttpGet(ECB_XML_ADDRESS);
-        HttpResponse response = client().execute(httpReq);
-        saxParser.parse(response.getEntity().getContent(), handler);
+        OkHttpClient client = new OkHttpClient.Builder()
+                .build();
+        Request request = new Request.Builder()
+                .url(ECB_XML_ADDRESS)
+                .get()
+                .build();
+        Response response = client.newCall(request).execute();
+        saxParser.parse(response.body().string(), handler);
     }
 
     @Test
@@ -83,11 +84,4 @@ public void testAvailableCurrencies() {
             AvailableCurrencies.valueOf(cube.getCurrency());
         });
     }
-
-    private CloseableHttpClient client() {
-        RequestConfig config = RequestConfig.custom()
-                .setCookieSpec(CookieSpecs.IGNORE_COOKIES)
-                .build();
-        return HttpClients.custom().setDefaultRequestConfig(config).build();
-    }
 }

rebot-plugins/rebot-karma-plugin/pom.xml

@@ -107,6 +107,9 @@
         <groupId>io.quarkus</groupId>
         <artifactId>quarkus-maven-plugin</artifactId>
         <version>${io.quarkus.version}</version>
+        <configuration>
+          <noDeps>true</noDeps>
+        </configuration>
         <executions>
           <execution>
             <goals>

rebot-plugins/rebot-welcome-message-plugin/pom.xml

@@ -126,6 +126,9 @@
         <groupId>io.quarkus</groupId>
         <artifactId>quarkus-maven-plugin</artifactId>
         <version>${io.quarkus.version}</version>
+        <configuration>
+          <noDeps>true</noDeps>
+        </configuration>
         <executions>
           <execution>
             <goals>

rebot-services/rebot-persistence-service/pom.xml

@@ -116,6 +116,9 @@
         <groupId>io.quarkus</groupId>
         <artifactId>quarkus-maven-plugin</artifactId>
         <version>${io.quarkus.version}</version>
+        <configuration>
+          <noDeps>true</noDeps>
+        </configuration>
         <executions>
           <execution>
             <goals>

rebot-telegram/pom.xml

@@ -124,6 +124,7 @@
         <groupId>io.quarkus</groupId>
         <artifactId>quarkus-maven-plugin</artifactId>
         <version>${io.quarkus.version}</version>
+
         <executions>
           <execution>
             <goals>