Expand NullToStrictIntPregSlitFuncCallLimitArgRector to support more functions

[codebymikey]

Feature Request

I appreciate the work done with rectorphp/rector-src#7240!

From testing some more legacy code through rector, it seems that a bunch of more functions require the null to int conversion (mainly the preg_* class of functions).

So I think it might be a good idea to abstract the NullToStrictIntPregSlitFuncCallLimitArgRector (slight typo) into a more flexible NullToStrictIntFuncCallArgRector, so something along the lines of this map can be incorporated for those functions (or make it configurable so that users can add their own functions or methods too):

I've added a 3v4l snippet to showcase the behaviour on PHP 7.4 vs 8.1:

• https://3v4l.org/dLJSU#v7.4.33
• https://3v4l.org/EllKE#v8.1.0

[TomasVotruba]

Hi, thanks for reporting.
Please send us PR with failing test fixture file, so we have it covered in tests. We'll look into it 👍

[TomasVotruba]

Closing as accepted: rectorphp/rector-src#7612 (comment)