Change to config_section

Author: smallcreep

README.md

@@ -156,8 +156,6 @@ If you want to replace specific value for keys you can use `replace` section.
 <filter pattern>
   @type record_modifier
 
-  # set replace to true, default false
-  replace true
   # replace key key1
   <replace>
     # your key name

lib/fluent/plugin/filter_record_modifier.rb

@@ -31,10 +31,21 @@ class Plugin::RecordModifierFilter < Plugin::Filter
 This option is exclusive with `remove_keys`.
 DESC
 
-    config_param :replace, :bool, default: false,
-                 desc: <<-DESC
-Boolean flag to enable replace function. Default is false.
-DESC
+    config_section :replace, param_name: :replaces, multi: true do
+                 desc"The field name to which the regular expression is applied"
+                 config_param :key, :string
+                 desc "The regular expression"
+                 config_param :expression do |value|
+                   if value.start_with?("/") && value.end_with?("/")
+                     Regexp.compile(value[1..-2])
+                   else
+                     $log.warn("You should use \"pattern /#{value}/\" instead of \"pattern #{value}\"")
+                     Regexp.compile(value)
+                   end
+                 end
+                 desc "The replacement string"
+                 config_param :replace, :string
+    end
 
     def configure(conf)
       super
@@ -71,20 +82,6 @@ def configure(conf)
         end
       end
 
-      @replace_keys = Array.new
-      if @replace
-        conf.elements.select { |element| element.name == 'replace' }.each do |element|
-          expr = if element['expression'][0] == "/" && element['expression'][-1] == "/"
-                   element['expression'][1..-2]
-                 else
-                   element['expression']
-                 end
-          @replace_keys.push("key" => element['key'],
-                             "expression" => Regexp.new(expr),
-                             "replace" => element['replace'])
-        end
-      end
-
       if @remove_keys and @whitelist_keys
         raise Fluent::ConfigError, "remove_keys and whitelist_keys are exclusive with each other."
       elsif @remove_keys
@@ -116,9 +113,9 @@ def filter(tag, time, record)
         record = modified
       end
 
-      if @replace && @replace_keys
-        @replace_keys.each {|rep|
-          record[rep['key']] = record[rep['key']].gsub(rep['expression'], rep['replace']) if record.include?(rep['key']) && rep['expression'].match(record[rep['key']])
+      if @replaces.any?
+        @replaces.each {|replace|
+          record[replace.key] = record[replace.key].gsub(replace.expression, replace.replace) if record.include?(replace.key) && replace.expression.match(record[replace.key])
         }
       end
 

test/test_filter_record_modifier.rb

@@ -143,7 +143,6 @@ def test_prepare_values
 
   def test_replace_values
     d = create_driver %[
-        replace true
         <replace>
           key k1
           expression /^(?<start>.+).{2}(?<end>.+)$/
@@ -165,7 +164,6 @@ def test_replace_values
 
   def test_does_not_replace
     d = create_driver %[
-        replace true
         <replace>
           key k1
           expression /^(?<start>.+).{2}(?<end>.+)$/