Skip to content

Commit a1366c4

Browse files
committed
Do we need shell-job?
1 parent bb7a47e commit a1366c4

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

internal/checkpointer/checkpointer.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ func (c *checkpointer) Checkpoint(ctx context.Context, cogletCmd *exec.Cmd, wait
163163
}
164164

165165
// CRIU checkpoint (leaving process running)
166-
cmd = exec.CommandContext(ctx, criuPath, "dump", "--leave-running", "--shell-job", "--tcp-close", "--images-dir", filepath.Join(c.checkpointDir, checkpointSubdirName), "--tree", pid)
166+
cmd = exec.CommandContext(ctx, criuPath, "dump", "--leave-running", "--tcp-close", "--images-dir", filepath.Join(c.checkpointDir, checkpointSubdirName), "--tree", pid)
167167
if err := cmd.Run(); err != nil {
168168
// Try to toggle CUDA back on. If we aren't able to restart CUDA, the process
169169
// will hang indefinitely, so we should kill it and try to start a new one
@@ -205,7 +205,7 @@ func (c *checkpointer) Restore(ctx context.Context) (*exec.Cmd, func(context.Con
205205
}
206206

207207
// Set up restore command
208-
restoreCmd := exec.CommandContext(ctx, criuPath, "restore", "--shell-job", "--tcp-close", "--images-dir", filepath.Join(c.checkpointDir, checkpointSubdirName))
208+
restoreCmd := exec.CommandContext(ctx, criuPath, "restore", "--tcp-close", "--images-dir", filepath.Join(c.checkpointDir, checkpointSubdirName))
209209

210210
// Set up callback function once restore is started
211211
callback := func(con context.Context) error {

0 commit comments

Comments
 (0)