docs: Update react tests task #1866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kravaring
reviewed
Nov 9, 2025
Collaborator
kravaring
left a comment
kravaring
left a comment
There was a problem hiding this comment.
Please, add AC for all features, otherwise looks good!
kravaring
reviewed
Nov 9, 2025
react/modules/tasks/tests.md
Outdated
|
|
||
| **Acceptance Criteria:** | ||
|
|
||
| - No changes are made to the logic or structure of class components during testing. |
Collaborator
There was a problem hiding this comment.
Hmm.. We had an issue with such restriction last time, so we had to allow refactoring in this module. I suggest allowing doing the refactoring.
Suggested change
| - No changes are made to the logic or structure of class components during testing. | |
| - No major changes are made to the logic or structure of class components during testing. | |
| - Conversion to functional components is not performed. | |
| - Only changes to improve testability are allowed, without altering behavior. |
kravaring
reviewed
Nov 9, 2025
react/modules/tasks/tests.md
Outdated
| **Acceptance Criteria:** | ||
|
|
||
| - Tests focus on user-visible behavior and component outputs, not internal implementation details. | ||
| - Tests remain valid after refactoring to functional components. |
Collaborator
There was a problem hiding this comment.
Would be hard to achieve in this module, refactoring will be done in the next one. I suggest removing this line.
Co-authored-by: kravaring <[email protected]>
…es-school/tasks into feature/react-tests
kravaring
approved these changes
Nov 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title of Pull Request
Update react tests task
🤔 This is a
Description
https://github.com/rolling-scopes-school/tasks/blob/feature/react-tests/react/modules/tasks/tests.md