The client_sync from v18 onwards still uses the old `client_v17__list_unspent` macro

[oleonardolima]

As I've been working on bitcoindevkit/bdk#1826, where I use the v28 of electrsd/corepc-node_28_1 feature of electrsd, I faced an error:

JsonRpc(Json(Error("missing field `account`", line: 1, column: 576))).

As I understand it's caused by the account field being deprecated from the RPC listunspent method, but the newer versions of clients in corepc still use the v17 macro.

It's a bug, right, and it should be updated to use the v18 onward versions of the macro, right ?

Please let me know if I'm missing something.

[tcharding]

Thanks for the bug report.

It's a bug, right, and it should be updated to use the v18 onward versions of the macro, right ?

Its a bug but its not the macro that is causing it. This issue highlights though that the macro names are confusing because I had to spend a couple of minutes to workout what the v17 in the macro meant. The macro doesn't matter as long as there are no changes to the function it defines. The exact types in scope when the macro is called are what effects the version. So if you look, for example, in client::client_sync::v28 you'll see that we wildcard import all the types from client::types::v28 (which is a re-export of the types crate).

Exactly what is causing this bug I don't know ATM, either I or @jamillambert will dig into it for you.

Thanks Leo!