-
Notifications
You must be signed in to change notification settings - Fork 14k
Add new failed_merged_doctest_compilation rustdoc lint
#148866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add new failed_merged_doctest_compilation rustdoc lint
#148866
Conversation
|
|
|
@bors2 try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…compilation, r=<try> Add new `failed_merged_doctest_compilation` rustdoc lint
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
Another thing I thought: should we display errors? |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (fa55e90): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 1.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -1.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 474.976s -> 474.831s (-0.03%) |
Finally took the time to write this lint. We need to have a compiler context in order to be able to emit the lint, but I'm not sure if
DiagCtxtHandledoesn't provide it somehow... Anyway, I'm expecting performance regression because we keep the compiler and its internals around for much longer, stacking doctests memory on top of the allocated memory to the current crate (which is why I'd really love to see if it's possible to emit lints fromDiagCtxtHandlesomehow, gonna investigate).Also: both lint name and lint message are very much up to debate.
r? @fmease