regression: Dockerfile ENV clobbers config.json settings

[pztrick]

The app port and virtual path used to be configurable from config.json in the past but now values for WOLWEBPORT and WOLWEBVDIR are baked into the Dockerfile and these will always override any values in config.json.

ARG WOLWEBPORT=8089
ARG WOLWEBVDIR=/wolweb
ENV WOLWEBPORT=${WOLWEBPORT}
ENV WOLWEBVDIR=${WOLWEBVDIR}

Adding new values in config.json are ignored:

{
    "host": "0.0.0.0",
    "port": 1234,
    "vdir": "/something-new"
}

From the README:

You can override the default application configuration by using a config file or by setting environment variables. The application will first load values from config file and look for environment variables and overwrites values from the file with the values which were found in the environment.

Removing the ENV assignments from the Dockerfile image should allow config.json to define the defaults, while still letting runtime environment variables override them as documented.