Skip to content

Commit 8eabddc

Browse files
committed
fix: delete query parameters
1 parent 08d1a77 commit 8eabddc

File tree

3 files changed

+23
-4
lines changed

3 files changed

+23
-4
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "elastic-tiny-client",
3-
"version": "0.1.1",
3+
"version": "0.1.2",
44
"main": "lib/index.js",
55
"scripts": {
66
"build": "tsc && node scripts/copy-data.mjs",

src/__tests__/elastic-client.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,7 @@ describe('elastic-client', () => {
126126
const result = await client.delete({
127127
index: 'hello-world',
128128
id: '1',
129+
refresh: true,
129130
})
130131
expect(result.code).toBe(200)
131132
})
@@ -137,9 +138,9 @@ describe('elastic-client', () => {
137138
index: 'hello-world2',
138139
document: { hello: true },
139140
id: '21',
141+
refresh: true,
140142
})
141143

142-
await client.refreshIndex({ index: 'hello-world2' })
143144
await client.deleteByQuery({
144145
index: 'hello-world2',
145146
query: {
@@ -150,7 +151,6 @@ describe('elastic-client', () => {
150151
refresh: true,
151152
})
152153

153-
await client.refreshIndex({ index: 'hello-world2' })
154154
const search = await client.search({
155155
index: 'hello-world2',
156156
query: {

src/elastic-client.ts

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -324,8 +324,27 @@ export class ElasticClient {
324324
}
325325

326326
async delete(params: DeleteRequest): Promise<Response<DeleteResponse>> {
327-
const url = `/${params.index}/_doc/${params.id}`
327+
let url = `/${params.index}/_doc/${params.id}`
328328

329+
const queryParams = queryParametersGenerator(
330+
{
331+
id: params.id,
332+
index: params.index,
333+
if_primary_term: params.if_primary_term,
334+
if_seq_no: params.if_seq_no,
335+
refresh: params.refresh,
336+
routing: params.routing,
337+
timeout: params.timeout,
338+
version: params.version,
339+
version_type: params.version_type,
340+
wait_for_active_shards: params.wait_for_active_shards,
341+
},
342+
params
343+
)
344+
if (queryParams) {
345+
url += `?${queryParams}`
346+
}
347+
delete params.index
329348
return await this.fetch(url, {
330349
method: 'DELETE',
331350
headers: this.#headers,

0 commit comments

Comments
 (0)