Skip to content

Graceful or Gracefull for worker-statefulset value #74

@santosr2

Description

@santosr2

Note

This issue is imported from the original repository: airflow-helm#105

Currently going through v8 of the chart (really nice btw) and noticed that we spell graceful as gracefull in the context of the worker statefulset values. I tried looking online to see if there's a dictionary which spells it with two Ls, but some dictionaries didn't recognize it and others mentioned it as being the archaic version of graceful. I wanted to ask before putting up a PR, but is fixing the word to use the more modern common version of its spelling worth doing?

The main impact would be on the two chart values:

  • .Values.workers.celery.gracefullTerminationPeriod -> .Values.workers.celery.gracefulTerminationPeriod
  • .Values.workers.celery.gracefullTermination -> .Values.workers.celery.gracefulTermination

If it's better to package this change in the next major version bump, it can wait. Otherwise if it's worth making this change sooner rather than later I can put up a PR for it.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions