Skip to content

Commit 071525b

Browse files
committed
fix(rdb): wait for instance ready state before backup creation
1 parent 177c3c7 commit 071525b

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

internal/namespaces/rdb/v1/custom_benchmark_test.go

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -328,6 +328,10 @@ func BenchmarkBackupGet(b *testing.B) {
328328
meta["Instance"] = rdb.CreateInstanceResult{Instance: instance}
329329

330330
backupOpMu.Lock()
331+
if err := waitForInstanceReady(executeCmd, instance.ID, instanceReadyTimeout); err != nil {
332+
backupOpMu.Unlock()
333+
b.Fatalf("Instance not ready before backup: %v", err)
334+
}
331335
err := createBackupDirect("Backup")(ctx)
332336
backupOpMu.Unlock()
333337

@@ -393,11 +397,19 @@ func BenchmarkBackupList(b *testing.B) {
393397
meta["Instance"] = rdb.CreateInstanceResult{Instance: instance}
394398

395399
backupOpMu.Lock()
400+
if err := waitForInstanceReady(executeCmd, instance.ID, instanceReadyTimeout); err != nil {
401+
backupOpMu.Unlock()
402+
b.Fatalf("Instance not ready before backup 1: %v", err)
403+
}
396404
err := createBackupDirect("Backup1")(ctx)
397405
if err != nil {
398406
backupOpMu.Unlock()
399407
b.Fatalf("Failed to create backup 1: %v", err)
400408
}
409+
if err := waitForInstanceReady(executeCmd, instance.ID, instanceReadyTimeout); err != nil {
410+
backupOpMu.Unlock()
411+
b.Fatalf("Instance not ready before backup 2: %v", err)
412+
}
401413
err = createBackupDirect("Backup2")(ctx)
402414
backupOpMu.Unlock()
403415

0 commit comments

Comments
 (0)