fix(baremetal): unset PN (#3533)

* fix(baremetal): unset PN

* update cassettes

Author: Laure-di

internal/services/baremetal/server.go

@@ -705,9 +705,11 @@ func ResourceServerUpdate(ctx context.Context, d *schema.ResourceData, m any) di
 			return diag.FromErr(err)
 		}
 
-		_, err = waitForServerPrivateNetwork(ctx, privateNetworkAPI, zone, baremetalPrivateNetwork.ServerPrivateNetworks[0].ServerID, d.Timeout(schema.TimeoutUpdate))
-		if err != nil && !httperrors.Is404(err) {
-			return diag.FromErr(err)
+		if baremetalPrivateNetwork.ServerPrivateNetworks != nil {
+			_, err = waitForServerPrivateNetwork(ctx, privateNetworkAPI, zone, baremetalPrivateNetwork.ServerPrivateNetworks[0].ServerID, d.Timeout(schema.TimeoutUpdate))
+			if err != nil && !httperrors.Is404(err) {
+				return diag.FromErr(err)
+			}
 		}
 	}
 

internal/services/baremetal/server_test.go

@@ -856,6 +856,49 @@ func TestAccServer_AddPrivateNetwork(t *testing.T) {
 			baremetalchecks.CheckServerDestroy(tt),
 		),
 		Steps: []resource.TestStep{
+			{
+				Config: fmt.Sprintf(`
+					data "scaleway_baremetal_os" "my_os" {
+						zone = "%s"
+						name = "Ubuntu"
+						version = "22.04 LTS (Jammy Jellyfish)"
+					}
+			
+					data "scaleway_baremetal_offer" "my_offer" {
+						zone = "%s"
+						name = "%s"
+					}
+			
+					data "scaleway_baremetal_option" "private_network" {
+						zone = "%s"
+						name = "Private Network"
+					}
+			
+					resource "scaleway_vpc_private_network" "pn" {
+						name = "baremetal_private_network"
+					}
+			
+					resource "scaleway_iam_ssh_key" "base" {
+						name 	   = "%s"
+						public_key = "%s"
+					}
+			
+					resource "scaleway_baremetal_server" "base" {
+						name        = "%s"
+						zone        = "%s"
+						offer       = data.scaleway_baremetal_offer.my_offer.offer_id
+						os          = data.scaleway_baremetal_os.my_os.os_id
+			
+						ssh_key_ids = [ scaleway_iam_ssh_key.base.id ]
+						options {
+						  id = data.scaleway_baremetal_option.private_network.option_id
+						}
+					}
+				`, Zone, Zone, OfferName, Zone, SSHKeyName, SSHKeyBaremetal, name, Zone),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckBaremetalServerExists(tt, "scaleway_baremetal_server.base"),
+				),
+			},
 			{
 				Config: fmt.Sprintf(`
 					data "scaleway_baremetal_os" "my_os" {
@@ -893,10 +936,15 @@ func TestAccServer_AddPrivateNetwork(t *testing.T) {
 						options {
 						  id = data.scaleway_baremetal_option.private_network.option_id
 						}
+						private_network {
+						  id = scaleway_vpc_private_network.pn.id
+						}
 					}
 				`, Zone, Zone, OfferName, Zone, SSHKeyName, SSHKeyBaremetal, name, Zone),
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckBaremetalServerExists(tt, "scaleway_baremetal_server.base"),
+					testAccCheckBaremetalServerHasPrivateNetwork(tt, "scaleway_baremetal_server.base"),
+					resource.TestCheckResourceAttrPair("scaleway_baremetal_server.base", "private_network.0.id", "scaleway_vpc_private_network.pn", "id"),
 				),
 			},
 			{
@@ -936,15 +984,11 @@ func TestAccServer_AddPrivateNetwork(t *testing.T) {
 						options {
 						  id = data.scaleway_baremetal_option.private_network.option_id
 						}
-						private_network {
-						  id = scaleway_vpc_private_network.pn.id
-						}
 					}
 				`, Zone, Zone, OfferName, Zone, SSHKeyName, SSHKeyBaremetal, name, Zone),
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckBaremetalServerExists(tt, "scaleway_baremetal_server.base"),
-					testAccCheckBaremetalServerHasPrivateNetwork(tt, "scaleway_baremetal_server.base"),
-					resource.TestCheckResourceAttrPair("scaleway_baremetal_server.base", "private_network.0.id", "scaleway_vpc_private_network.pn", "id"),
+					resource.TestCheckNoResourceAttr("scaleway_baremetal_server.base", "private_network.0"),
 				),
 			},
 		},