feat: make expires_at optional in MongoDB snapshot action and add audit trail verification

Author: jremy42

internal/services/mongodb/action_instance_snapshot_action.go

@@ -81,8 +81,8 @@ func (a *InstanceSnapshotAction) Schema(_ context.Context, _ action.SchemaReques
 				Description: "Name of the snapshot. If not set, a name will be generated.",
 			},
 			"expires_at": schema.StringAttribute{
-				Required:    true,
-				Description: "Expiration date of the snapshot in RFC3339 format (ISO 8601).",
+				Optional:    true,
+				Description: "Expiration date of the snapshot in RFC3339 format (ISO 8601). If not set, the snapshot will not expire.",
 			},
 			"wait": schema.BoolAttribute{
 				Optional:    true,
@@ -142,22 +142,27 @@ func (a *InstanceSnapshotAction) Invoke(ctx context.Context, req action.InvokeRe
 		snapshotName = "tf-mongodb-snapshot"
 	}
 
-	expirationRaw := data.ExpiresAt.ValueString()
+	var expirationTime *time.Time
+	if !data.ExpiresAt.IsNull() && data.ExpiresAt.ValueString() != "" {
+		expirationRaw := data.ExpiresAt.ValueString()
 
-	expirationTime, err := time.Parse(time.RFC3339, expirationRaw)
-	if err != nil {
-		resp.Diagnostics.AddError(
-			"Invalid expires_at value",
-			fmt.Sprintf("The expires_at attribute must be a valid RFC3339 timestamp. Got %q: %s", expirationRaw, err),
-		)
+		parsedTime, err := time.Parse(time.RFC3339, expirationRaw)
+		if err != nil {
+			resp.Diagnostics.AddError(
+				"Invalid expires_at value",
+				fmt.Sprintf("The expires_at attribute must be a valid RFC3339 timestamp. Got %q: %s", expirationRaw, err),
+			)
 
-		return
+			return
+		}
+
+		expirationTime = &parsedTime
 	}
 
 	createReq := &mongodb.CreateSnapshotRequest{
 		InstanceID: instanceID,
 		Name:       snapshotName,
-		ExpiresAt:  &expirationTime,
+		ExpiresAt:  expirationTime,
 	}
 
 	if region != "" {

internal/services/mongodb/action_instance_snapshot_action_test.go

@@ -1,9 +1,12 @@
 package mongodb_test
 
 import (
+	"errors"
+	"strings"
 	"testing"
 
 	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
+	"github.com/hashicorp/terraform-plugin-testing/terraform"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/acctest"
 )
 
@@ -46,6 +49,61 @@ func TestAccActionMongoDBInstanceSnapshot_Basic(t *testing.T) {
 					}
 				`,
 			},
+			{
+				Config: `
+					resource "scaleway_mongodb_instance" "main" {
+						name        = "test-mongodb-action-snapshot"
+						version     = "7.0.12"
+						node_type   = "MGDB-PLAY2-NANO"
+						node_number = 1
+						user_name   = "my_initial_user"
+						password    = "thiZ_is_v&ry_s3cret"
+
+						lifecycle {
+							action_trigger {
+								events  = [after_create]
+								actions = [action.scaleway_mongodb_instance_snapshot_action.main]
+							}
+						}
+					}
+
+					action "scaleway_mongodb_instance_snapshot_action" "main" {
+						config {
+							instance_id = scaleway_mongodb_instance.main.id
+							name        = "tf-acc-mongodb-instance-snapshot-action"
+							expires_at  = "2026-11-01T00:00:00Z"
+							wait        = true
+						}
+					}
+
+					data "scaleway_audit_trail_event" "mongodb" {
+						resource_type = "mongodb_instance"
+						resource_id   = scaleway_mongodb_instance.main.id
+						method_name    = "CreateSnapshot"
+					}
+				`,
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttrSet("data.scaleway_audit_trail_event.mongodb", "events.#"),
+					func(state *terraform.State) error {
+						rs, ok := state.RootModule().Resources["data.scaleway_audit_trail_event.mongodb"]
+						if !ok {
+							return errors.New("not found: data.scaleway_audit_trail_event.mongodb")
+						}
+
+						for key, value := range rs.Primary.Attributes {
+							if !strings.Contains(key, "request_body") {
+								continue
+							}
+
+							if strings.Contains(value, "tf-acc-mongodb-instance-snapshot-action") {
+								return nil
+							}
+						}
+
+						return errors.New("did not find the CreateSnapshot event")
+					},
+				),
+			},
 		},
 	})
 }