Rename ExceptionHelper to Throw and shorter method names (#2148)

Author: lahma

Jint.Tests.Test262/Test262ModuleLoader.cs

@@ -29,7 +29,7 @@ protected override string LoadModuleContents(Engine engine, ResolvedSpecifier re
             var fileName = Path.Combine(_basePath, resolved.Key).Replace('\\', '/');
             if (!_fileSystem.FileExists(fileName))
             {
-                ExceptionHelper.ThrowModuleResolutionException("Module Not Found", resolved.ModuleRequest.Specifier, parent: null, fileName);
+                Throw.ModuleResolutionException("Module Not Found", resolved.ModuleRequest.Specifier, parent: null, fileName);
             }
             using var stream = new StreamReader(_fileSystem.OpenFile(fileName, FileMode.Open, FileAccess.Read));
             return stream.ReadToEnd();

Jint/AstExtensions.cs

@@ -27,7 +27,7 @@ public static JsValue GetKey(this Expression expression, Engine engine, bool res
             return TypeConverter.ToPropertyKey(key);
         }
 
-        ExceptionHelper.ThrowArgumentException("Unable to extract correct key, node type: " + expression.Type);
+        Throw.ArgumentException("Unable to extract correct key, node type: " + expression.Type);
         return JsValue.Undefined;
     }
 
@@ -324,7 +324,7 @@ internal static Record DefineMethod<T>(this T m, ObjectInstance obj, ObjectInsta
         var function = m.Value as IFunction;
         if (function is null)
         {
-            ExceptionHelper.ThrowSyntaxError(engine.Realm);
+            Throw.SyntaxError(engine.Realm);
         }
 
         var definition = new JintFunctionDefinition(function);
@@ -552,7 +552,7 @@ protected override object VisitClassBody(ClassBody classBody)
         [MethodImpl(MethodImplOptions.NoInlining)]
         private static void Throw(Realm r, PrivateIdentifier id)
         {
-            ExceptionHelper.ThrowSyntaxError(r, $"Private field '#{id.Name}' must be declared in an enclosing class");
+            Runtime.Throw.SyntaxError(r, $"Private field '#{id.Name}' must be declared in an enclosing class");
         }
     }
 }

Jint/Collections/ListDictionary.cs

@@ -85,7 +85,7 @@ public bool Add(Key key, TValue value, bool tryAdd = false)
                 {
                     return false;
                 }
-                ExceptionHelper.ThrowArgumentException();
+                Throw.ArgumentException();
             }
 
             last = node;

Jint/Collections/ObjectTraverseStack.cs

@@ -20,7 +20,7 @@ public bool TryEnter(JsValue value)
     {
         if (value is null)
         {
-            ExceptionHelper.ThrowArgumentNullException(nameof(value));
+            Throw.ArgumentNullException(nameof(value));
         }
 
         if (_stack.Contains(value))
@@ -37,7 +37,7 @@ public void Enter(JsValue value)
     {
         if (!TryEnter(value))
         {
-            ExceptionHelper.ThrowTypeError(_engine.Realm, "Cyclic reference detected.");
+            Throw.TypeError(_engine.Realm, "Cyclic reference detected.");
         }
     }
 

Jint/Collections/RefStack.cs

@@ -54,7 +54,7 @@ public ref readonly T Pop()
     {
         if (_size == 0)
         {
-            ExceptionHelper.ThrowInvalidOperationException("stack is empty");
+            Throw.InvalidOperationException("stack is empty");
         }
 
         _size--;

Jint/Constraints/CancellationConstraint.cs

@@ -16,7 +16,7 @@ public override void Check()
     {
         if (_cancellationToken.IsCancellationRequested)
         {
-            ExceptionHelper.ThrowExecutionCanceledException();
+            Throw.ExecutionCanceledException();
         }
     }
 

Jint/Constraints/MaxStatementsConstraint.cs

@@ -20,7 +20,7 @@ public override void Check()
     {
         if (MaxStatements > 0 && ++_statementsCount > MaxStatements)
         {
-            ExceptionHelper.ThrowStatementsCountOverflowException();
+            Throw.StatementsCountOverflowException();
         }
     }
 

Jint/Constraints/MemoryLimitConstraint.cs

@@ -38,14 +38,14 @@ public override void Check()
 #else
         if (_getAllocatedBytesForCurrentThread == null)
         {
-            ExceptionHelper.ThrowPlatformNotSupportedException("The current platform doesn't support MemoryLimit.");
+            Throw.PlatformNotSupportedException("The current platform doesn't support MemoryLimit.");
         }
 
         var usage = _getAllocatedBytesForCurrentThread();
 #endif
         if (usage - _initialMemoryUsage > _memoryLimit)
         {
-            ExceptionHelper.ThrowMemoryLimitExceededException($"Script has allocated {usage - _initialMemoryUsage} but is limited to {_memoryLimit}");
+            Throw.MemoryLimitExceededException($"Script has allocated {usage - _initialMemoryUsage} but is limited to {_memoryLimit}");
         }
     }
 

Jint/Constraints/TimeConstraint.cs

@@ -19,7 +19,7 @@ public override void Check()
     {
         if (_cts?.IsCancellationRequested == true)
         {
-            ExceptionHelper.ThrowTimeoutException();
+            Throw.TimeoutException();
         }
     }
 

Jint/Engine.Modules.cs

@@ -131,7 +131,7 @@ internal ObjectInstance Import(ModuleRequest request, string? referencingModuleL
 
                 if (cyclicModule.Status != ModuleStatus.Evaluated)
                 {
-                    ExceptionHelper.ThrowNotSupportedException($"Error while evaluating module: Module is in an invalid state: '{cyclicModule.Status}'");
+                    Throw.NotSupportedException($"Error while evaluating module: Module is in an invalid state: '{cyclicModule.Status}'");
                 }
             }
 
@@ -165,7 +165,7 @@ private JsValue EvaluateModule(string specifier, Module module)
             // This should instead be returned and resolved in ImportModule(specifier) only so Host.ImportModuleDynamically can use this promise
             if (evaluationResult is not JsPromise promise)
             {
-                ExceptionHelper.ThrowInvalidOperationException($"Error while evaluating module: Module evaluation did not return a promise: {evaluationResult.Type}");
+                Throw.InvalidOperationException($"Error while evaluating module: Module evaluation did not return a promise: {evaluationResult.Type}");
             }
             else if (promise.State == PromiseState.Rejected)
             {
@@ -174,11 +174,11 @@ private JsValue EvaluateModule(string specifier, Module module)
                     : SourceLocation.From(new Position(), new Position());
 
                 var node = AstExtensions.CreateLocationNode(location);
-                ExceptionHelper.ThrowJavaScriptException(_engine, promise.Value, node.Location);
+                Throw.JavaScriptException(_engine, promise.Value, node.Location);
             }
             else if (promise.State != PromiseState.Fulfilled)
             {
-                ExceptionHelper.ThrowInvalidOperationException($"Error while evaluating module: Module evaluation did not return a fulfilled promise: {promise.State}");
+                Throw.InvalidOperationException($"Error while evaluating module: Module evaluation did not return a fulfilled promise: {promise.State}");
             }
 
             return evaluationResult;