-
-
Notifications
You must be signed in to change notification settings - Fork 507
feat(discover): add TMDB lists as custom-slider #1896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat(discover): add TMDB lists as custom-slider #1896
Conversation
|
Can a preview be done this ? |
I think you would like to ask if I can show you a little preview? :) If you wanna build this with docker and try this on your own: Then you can use a compose.yaml like this: services:
jellyseerr:
build:
#THIS MUST BE THE PATH WHERE YOU CLONE MY FORK INTO
context: ./jellyseerr-tmdb-lists-feat/
dockerfile: Dockerfile.local
args:
COMMIT_TAG: local
image: jellyseerr-fork:dev
container_name: jellyseerr-fork
environment:
- LOG_LEVEL=debug
- TZ=Europe/London
- PORT=5055 # optional
- COMMIT_TAG=local # <<< important: you need this Build-ARG
network_mode: host
ports:
- 5055:5055
restart: no |
Thank you for responding, but the message was addressed to the dev team cause they can launch a GitHub CI to make a Docker image of your PR so we can test it |
|
Beware, low-effort AI slop. |
…eerr-team#1491) * feat(wehbook): add support for dynamic placeholders in webhook URL * refactor(webhook): rename supportPlaceholders to supportVariables and update related logic Signed-off-by: 0xsysr3ll <[email protected]> * feat(i18n): add missing translations Signed-off-by: 0xsysr3ll <[email protected]> * refactor(notifications): simplify webhook URL validation logic Signed-off-by: 0xsysr3ll <[email protected]> * fix: wrong docs url Co-authored-by: Gauthier <[email protected]> * fix: update webhook documentation URL to point to Jellyseerr Signed-off-by: 0xsysr3ll <[email protected]> --------- Signed-off-by: 0xsysr3ll <[email protected]> Co-authored-by: Gauthier <[email protected]>
…team#1908) Signed-off-by: 0xsysr3ll <[email protected]>
…caching (seerr-team#1910) * fix: ensure dnsCache is checked for when its enabled before initialization previously dnsCache was being initialized even if it was disabled because the previous check was always returning truthy. fix seerr-team#1857 * chore: update dns-caching to 0.2.6 This will allow dns-caching to respect forceIpv4 flag. * chore: update dns-caching to 0.2.7
Jellyseerr is not designed to support multiple concurrently running instances. To ensure that only one instance can run at any given time we: - Replace Deployment with StatefulSet: switch from running "at least N pods" to "at most N pods". - Remove replicaCount value: default is 1, we do not want to support more.
* docs: add AI assistance notice * docs: add TODO item for AI disclosure
This PR removes the spaces in the tags sent to *arr when the Tag Requests option is enabled. Spaces in tags are an unintended behavior and are not longer supported. fix seerr-team#1897
* feat(ci): tidy up workflows and implement a consistent style all workflows now use ubuntu-24.04 as the runner type to match the release workflows codeql.yml - bump actions to v3 - add least-privilege perms + concurrency to stop duplicate runs - ignore docs only changes conflict_labeler.yml - run on opened, reopened, and synchronize - bump action version - add concurrency group to avoid duplicate labeling cypress.yml - skip docs-only changes; don’t run on draft PRs - add concurrency to stop duplicate runs + 10m timeout docs-deploy.yml - add configure-pages@v5 and bump upload-pages-artifact to v4 - set explicit pages/id-token perms + concurrency - minor cleanups (working-directory, ubuntu-24.04) helm.yml - switch oras discover to oras manifest fetch - add concurrency to stop duplicate runs lint-helm-charts.yml - bump action versions - enforce version bumps (--check-version-increment=true) - add least-privilege perms + concurrency to stop duplicate runs support.yml - add least-privilege perms test-docs-deploy.yml - add least-privilege perms + concurrency to stop duplicate runs * fixed line 5 syntax error * Updated based on comments from @M0NsTeRRR in PR-1905 discussion * updated based on 2nd review from @M0NsTeRRR in PR-1905 * Merge of PR-1904 and PR-1905 * chore(pnpm-lock.yaml): updated the pnpm-lockfile * ci(release.yml): fix the latest tag to use context labels * ci: fix new lines at eof, removed cypress timeout, removed legacy qemu actions * @M0NsTeRRR self review Signed-off-by: Ludovic Ortega <[email protected]> * fix: support workflow Signed-off-by: Ludovic Ortega <[email protected]> * fix: newline --------- Signed-off-by: Ludovic Ortega <[email protected]> Co-authored-by: Ludovic Ortega <[email protected]> Co-authored-by: Ludovic Ortega <[email protected]>
* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
…am#2037) This PR fixes an issue where removing 4K movies from Radarr failed when multiple Radarr instances were configured. The backend was misparsing boolean query parameters and using string slugs instead of TMDB IDs. The fix ensures that the correct 4K Radarr instance is targeted and that TMDB IDs are used for movie removal. Signed-off-by: 0xsysr3ll <[email protected]>
…team#1951) Signed-off-by: 0xsysr3ll <[email protected]>
…eerr-team#1736) * fix: include video content in the blacklisted tags processing job Modified the “blacklisted tags” job to include adult & video content, this correctly blacklists more adult films that were always missed, even if they had the tag. * refactor: remove dead code * refactor: remove redundant explicit arguments
* feat: add Overseerr migration * refactor: rename to Seerr * refactor: more rename to Seerr * feat: update the value of the MediaStatus.DELETED enum * fix: add more details in migration logs * fix: replace .update by .save for TypeORM hooks * fix: add fake migration to skip the duplicated UpdateWebPush migration * fix: rewrite the AddUserAvatarCacheFields migration for Overseerr merge * fix: replace jellyseerr migrations with a dedicated one for overseerr * fix: update overseerr migration * fix: update overseerr migration * fix: remove irrelevant changes * fix: typos * docs: update jsdoc comment * docs: update seerr description * docs: fix the contributing.md link * fix: remove unwanterd change on postgres dev datasource * docs: add latest tag to docker image * fix: migrate old deleted status for 4k media * fix: update Seerr version check
Signed-off-by: Ludovic Ortega <[email protected]>
…ages (seerr-team#2128) Signed-off-by: 0xsysr3ll <[email protected]>
…seerr-team#2146) This PR fixes the issue where custom images built with `--build-arg COMMIT_TAG` would fail because the client bundle didn't receive the commit tag value. Signed-off-by: 0xsysr3ll <[email protected]>
Signed-off-by: 0xsysr3ll <[email protected]>
…r-team#2154) Signed-off-by: 0xsysr3ll <[email protected]>
Signed-off-by: Ludovic Ortega <[email protected]>
Signed-off-by: Ludovic Ortega <[email protected]>
Signed-off-by: Ludovic Ortega <[email protected]>
support creating discover sliders from public tmdb lists
|
So, I finally managed to complete this 👍 Just a brief note regarding your new contribution guidelines: For this update, I used an AI tool purely as a supportive tool — mainly to better understand certain parts of the codebase and to streamline the development and merge process. In addition, I thoroughly tested the feature. I believe this feature is a nice value-add for Seerr. If any adjustments or further tests are needed, feel free to let me know 👍 |
fallenbagel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, this PR cannot be reviewed nor merged as it is. It has picked up all commits from develop, showing 121 commits instead of just your TMDB list changes.
To fix this, you'll need to rebase your branch on the latest develop or create a fresh branch with only your original commits, then force push. Happy to review once the PR shows only your changes.
oh, upsi. I will check this. Thanks for your time 👍 |
Description
This PR introduces a new discovery slider type (
TMDB_LIST) that allows administrators to configure a public TMDB list ID and display its items.Built and tested locally with Docker (
Dockerfile.local), slider works as expected.Screenshot (if UI-related)
To-Dos
pnpm buildpnpm i18n:extract(New keys such as
tmdbListandprovidetmdblistidwere added and need to be present in the i18n schema.)Issues Fixed or Closed