Add vector epoch orbit solving API & vectorized Markley implementation via LoopVectorization #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements a new API for solving orbits at multiple epochs simultaneously:
1. Generic fallback implementation:
- orbitsolve(orbit, epochs::AbstractVector) loops over each epoch
- Works with any solver type and orbit type
2. Automatic solver selection:
- orbitsolve(orbit, epochs, Auto()) automatically dispatches to
vectorized Markley solver for elliptical orbits (e < 1)
- Falls back to generic implementation for hyperbolic orbits
3. Vectorized Markley solver:
- orbitsolve(orbit, epochs, Markley()) uses SIMD-optimized
vectorized Kepler equation solving
- Implements kepler_solver_phased! with phased computation:
* Phase 1: Range reduction (fully SIMD)
* Phase 2: Algebraic computation (partially SIMD)
* Phase 3: Newton refinement (SIMD with trig functions)
- Solves all Kepler equations at once for improved performance
The implementation is minimal and generic, dispatching correctly based on
solver type while maintaining backwards compatibility with existing code.
Tests added in test/test_vectorized_orbitsolve.jl verify correctness
across different orbit types and solvers.
- Add Bumper.jl dependency to Project.toml - Use @no_escape and @alloc macros for temporary workspace allocations - Eliminates allocation overhead when repeatedly calling with same number of epochs - Arena allocator provides stack-like performance for temporary buffers
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17 +/- ##
==========================================
+ Coverage 26.11% 32.74% +6.63%
==========================================
Files 15 15
Lines 1187 1310 +123
==========================================
+ Hits 310 429 +119
- Misses 877 881 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.