v3 action

Author: blindchaser

.github/workflows/codeql.yml

@@ -22,7 +22,7 @@ jobs:
     steps:
       - name: Checkout repository
         uses: actions/checkout@v3
-      - uses: actions/setup-go@v4
+      - uses: actions/setup-go@v3
         with:
           go-version: '1.22'
       - name: Install RELIC dependencies

.github/workflows/golangci.yml

@@ -15,7 +15,7 @@ jobs:
     name: lint
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/setup-go@v4
+      - uses: actions/setup-go@v3
         with:
           go-version: '1.22'
       - uses: actions/checkout@v3
@@ -40,7 +40,7 @@ jobs:
           echo "CGO_CFLAGS=-I/usr/local/include/relic -DRLC_NO_CORE" >> $GITHUB_ENV
           echo "CGO_LDFLAGS=-L/usr/local/lib -lrelic_s" >> $GITHUB_ENV
           echo "LD_LIBRARY_PATH=/usr/local/lib:$LD_LIBRARY_PATH" >> $GITHUB_ENV
-      - uses: golangci/golangci-lint-action@v4
+      - uses: golangci/golangci-lint-action@v3
         with:
           version: v1.61
           args: --config=.golangci.yml --timeout=10m

.github/workflows/unit_tests.yml

@@ -13,7 +13,7 @@ jobs:
   tests:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/setup-go@v4
+      - uses: actions/setup-go@v3
         with:
           go-version: '1.22'
       - uses: actions/checkout@v3
@@ -41,7 +41,7 @@ jobs:
       - name: Run Go Tests
         run: |
           make test-all
-      - uses: actions/upload-artifact@v4
+      - uses: actions/upload-artifact@v3
         with:
           name: "${{ github.sha }}-coverage"
           path: ./profile.out
@@ -51,13 +51,13 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-      - uses: actions/setup-go@v4
+      - uses: actions/setup-go@v3
         with:
           go-version: '1.22'
 
       # Download all coverage reports from the 'tests' job
       - name: Download coverage reports
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v3
 
       - name: Set GOPATH
         run: echo "GOPATH=$(go env GOPATH)" >> $GITHUB_ENV

.golangci.yml

@@ -10,7 +10,7 @@ linters:
   enable:
     - bodyclose
     - dogsled
-    - exportloopref
+    - copyloopvar
     - errcheck
     - goconst
     - gocritic
@@ -38,6 +38,9 @@ issues:
     - text: "Use of weak random number generator"
       linters:
         - gosec
+    - text: "G115:" # Exclude integer overflow conversion warnings
+      linters:
+        - gosec
     - text: "ST1003:"
       linters:
         - stylecheck

sc/memiavl/filelock.go

@@ -3,7 +3,7 @@ package memiavl
 import (
 	"path/filepath"
 
-	"github.com/zbiljic/go-filelock"
+	filelock "github.com/zbiljic/go-filelock"
 )
 
 type FileLock interface {

ss/pebbledb/db.go

@@ -10,7 +10,7 @@ import (
 	"sync"
 	"time"
 
-	"github.com/armon/go-metrics"
+	metrics "github.com/armon/go-metrics"
 	"github.com/cockroachdb/pebble"
 	"github.com/cockroachdb/pebble/bloom"
 	errorutils "github.com/sei-protocol/sei-db/common/errors"

ss/pebbledb/hash_test.go

@@ -339,12 +339,18 @@ func TestAsyncComputeMissingRanges(t *testing.T) {
 	err := db.ApplyChangesetAsync(31, changesets)
 	require.NoError(t, err)
 
-	// Wait a bit for the async computation to complete
-	time.Sleep(200 * time.Millisecond)
+	// Wait for the async computation to complete with retries
+	var lastHashed int64
+	for retries := 0; retries < 50; retries++ {
+		lastHashed, err = db.GetLastRangeHashed()
+		require.NoError(t, err)
+		if lastHashed >= 30 {
+			break
+		}
+		time.Sleep(20 * time.Millisecond)
+	}
 
 	// We should now have hashed up to version 30 (3 complete ranges)
-	lastHashed, err := db.GetLastRangeHashed()
-	require.NoError(t, err)
 	assert.Equal(t, int64(30), lastHashed)
 
 	// Apply more changesets to get to version 40
@@ -353,12 +359,17 @@ func TestAsyncComputeMissingRanges(t *testing.T) {
 		require.NoError(t, err)
 	}
 
-	// Wait a bit for async computation
-	time.Sleep(500 * time.Millisecond)
+	// Wait for async computation to complete with retries
+	for retries := 0; retries < 50; retries++ {
+		lastHashed, err = db.GetLastRangeHashed()
+		require.NoError(t, err)
+		if lastHashed >= 40 {
+			break
+		}
+		time.Sleep(20 * time.Millisecond)
+	}
 
 	// We should now have hashed up to version 40
-	lastHashed, err = db.GetLastRangeHashed()
-	require.NoError(t, err)
 	assert.Equal(t, int64(40), lastHashed)
 }
 

ss/store_test.go

@@ -5,6 +5,7 @@ import (
 	"os"
 	"path/filepath"
 	"testing"
+	"time"
 
 	"github.com/cosmos/iavl"
 	"github.com/sei-protocol/sei-db/common/logger"
@@ -42,7 +43,24 @@ func TestNewStateStore(t *testing.T) {
 		err := stateStore.ApplyChangesetAsync(int64(i), changesets)
 		require.NoError(t, err)
 	}
-	// Closing the state store without waiting for data to be fully flushed
+
+	// Wait for all async operations to complete by checking latest version
+	// This ensures data is flushed before closing
+	var finalVersion int64
+	for retries := 0; retries < 50; retries++ {
+		finalVersion, err = stateStore.GetLatestVersion()
+		if err == nil && finalVersion >= 19 {
+			break
+		}
+		// Small sleep to allow async writes to complete
+		time.Sleep(10 * time.Millisecond)
+		if retries == 49 {
+			require.NoError(t, err)
+		}
+	}
+	require.Equal(t, int64(19), finalVersion, "Expected latest version to be 19 after async writes complete")
+
+	// Closing the state store after ensuring data is fully flushed
 	err = stateStore.Close()
 	require.NoError(t, err)