Skip to content

Commit 3541869

Browse files
committed
Fix issue with counting up jobs that didn't finish
We saw an issue with a negative amount for a new customer that only showed in the repo-level breakout. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
1 parent 873a22b commit 3541869

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

main.go

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -231,16 +231,18 @@ func main() {
231231
summary := repoSummary[owner+"/"+repo.GetName()]
232232

233233
for _, job := range jobs.Jobs {
234-
dur := job.GetCompletedAt().Time.Sub(job.GetStartedAt().Time)
235-
if dur > longestBuild {
236-
longestBuild = dur
237-
}
238-
if dur > summary.LongestBuild {
239-
summary.LongestBuild = dur
234+
if !job.GetCompletedAt().IsZero() {
235+
dur := job.GetCompletedAt().Time.Sub(job.GetStartedAt().Time)
236+
if dur > longestBuild {
237+
longestBuild = dur
238+
}
239+
if dur > summary.LongestBuild {
240+
summary.LongestBuild = dur
241+
}
242+
243+
summary.TotalTime += dur
240244
}
241245

242-
summary.TotalTime += dur
243-
244246
if _, ok := conclusion[job.GetConclusion()]; !ok {
245247
conclusion[job.GetConclusion()] = 0
246248
}

0 commit comments

Comments
 (0)