Fix bug: Incorrect variable used in rem_total_token_offset calculatio…

[liuhuijiayou]

For more details, see #13111.

[gemini-code-assist]

Summary of Changes

Hello @liuhuijiayou, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the scheduling policy where the wrong request object was being referenced during the calculation of remaining total token offset. By rectifying the variable used, the change ensures that the scheduler accurately accounts for token usage when preempting requests, leading to more reliable resource management and preventing potential miscalculations in the system's scheduling logic.

Highlights

• Bug Fix: Corrected an issue where an incorrect variable was used in the calculation of rem_total_token_offset within the preempt_to_schedule method, ensuring accurate token offset adjustments during request preemption.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a bug in the request preemption logic within PrefillAdder. The calculation of rem_total_token_offset was incorrectly using the token count of the new incoming request (req) instead of the request being preempted (running_req). This change corrects the variable used, ensuring the scheduler's memory accounting is accurate during preemption. The fix is correct and essential for the stability and correctness of the scheduling mechanism.