Skip to content

Commit 6631599

Browse files
luizhf42otavio
authored andcommitted
refactor(ui): remove unnecessary mocks and session recording store calls
1 parent 7ce3fff commit 6631599

40 files changed

+0
-150
lines changed

ui/tests/components/Billing/BillingDialog.spec.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,6 @@ describe("Billing Dialog", () => {
7979
],
8080
};
8181

82-
const session = true;
83-
8482
beforeEach(async () => {
8583
const el = document.createElement("div");
8684
document.body.appendChild(el);
@@ -93,15 +91,13 @@ describe("Billing Dialog", () => {
9391
mockBilling = new MockAdapter(billingApi.getAxios());
9492

9593
mockNamespace.onGet("http://localhost:3000/api/namespaces/fake-tenant-data").reply(200, namespaceData);
96-
mockUser.onGet("http://localhost:3000/api/users/security").reply(200, session);
9794
mockUser.onGet("http://localhost:3000/api/auth/user").reply(200, authData);
9895
mockBilling.onPost("http://localhost:3000/api/billing/customer").reply(200);
9996
mockBilling.onGet("http://localhost:3000/api/billing/customer").reply(200, customerData);
10097

10198
store.commit("auth/authSuccess", authData);
10299
store.commit("auth/changeData", authData);
103100
store.commit("namespaces/setNamespace", namespaceData);
104-
store.commit("security/setSecurity", session);
105101

106102
wrapper = mount(BillingDialog, {
107103
global: {

ui/tests/components/Connectors/ConnectorAdd.spec.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,6 @@ describe("Connector Add", () => {
6161
},
6262
};
6363

64-
const session = true;
65-
6664
beforeEach(async () => {
6765
const el = document.createElement("div");
6866
document.body.appendChild(el);
@@ -74,13 +72,11 @@ describe("Connector Add", () => {
7472
mockUser = new MockAdapter(usersApi.getAxios());
7573

7674
mockNamespace.onGet("http://localhost:3000/api/namespaces/fake-tenant-data").reply(200, namespaceData);
77-
mockUser.onGet("http://localhost:3000/api/users/security").reply(200, session);
7875
mockUser.onGet("http://localhost:3000/api/auth/user").reply(200, authData);
7976

8077
store.commit("auth/authSuccess", authData);
8178
store.commit("auth/changeData", authData);
8279
store.commit("namespaces/setNamespace", namespaceData);
83-
store.commit("security/setSecurity", session);
8480

8581
wrapper = mount(ConnectorAdd, {
8682
global: {

ui/tests/components/Connectors/ConnectorDelete.spec.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,6 @@ describe("Connector Delete", () => {
6161
},
6262
};
6363

64-
const session = true;
65-
6664
beforeEach(async () => {
6765
const el = document.createElement("div");
6866
document.body.appendChild(el);
@@ -74,14 +72,12 @@ describe("Connector Delete", () => {
7472
mockUser = new MockAdapter(usersApi.getAxios());
7573

7674
mockNamespace.onGet("http://localhost:3000/api/namespaces/fake-tenant-data").reply(200, namespaceData);
77-
mockUser.onGet("http://localhost:3000/api/users/security").reply(200, session);
7875
mockUser.onGet("http://localhost:3000/api/auth/user").reply(200, authData);
7976
mockUser.onGet("http://localhost:3000/api/auth/user").reply(200, authData);
8077

8178
store.commit("auth/authSuccess", authData);
8279
store.commit("auth/changeData", authData);
8380
store.commit("namespaces/setNamespace", namespaceData);
84-
store.commit("security/setSecurity", session);
8581
wrapper = mount(ConnectorDelete, {
8682
global: {
8783
plugins: [[store, key], vuetify, router, SnackbarPlugin],

ui/tests/components/Connectors/ConnectorEdit.spec.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,6 @@ describe("Connector Edit", () => {
6161
},
6262
};
6363

64-
const session = true;
65-
6664
beforeEach(async () => {
6765
const el = document.createElement("div");
6866
document.body.appendChild(el);
@@ -74,13 +72,11 @@ describe("Connector Edit", () => {
7472
mockUser = new MockAdapter(usersApi.getAxios());
7573

7674
mockNamespace.onGet("http://localhost:3000/api/namespaces/fake-tenant-data").reply(200, namespaceData);
77-
mockUser.onGet("http://localhost:3000/api/users/security").reply(200, session);
7875
mockUser.onGet("http://localhost:3000/api/auth/user").reply(200, authData);
7976

8077
store.commit("auth/authSuccess", authData);
8178
store.commit("auth/changeData", authData);
8279
store.commit("namespaces/setNamespace", namespaceData);
83-
store.commit("security/setSecurity", session);
8480

8581
wrapper = mount(ConnectorEdit, {
8682
global: {

ui/tests/components/Connectors/ConnectorForm.spec.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,6 @@ describe("Connector Form", () => {
6161
},
6262
};
6363

64-
const session = true;
65-
6664
beforeEach(async () => {
6765
const el = document.createElement("div");
6866
document.body.appendChild(el);
@@ -76,13 +74,11 @@ describe("Connector Form", () => {
7674
mockUser = new MockAdapter(usersApi.getAxios());
7775

7876
mockNamespace.onGet("http://localhost:3000/api/namespaces/fake-tenant-data").reply(200, namespaceData);
79-
mockUser.onGet("http://localhost:3000/api/users/security").reply(200, session);
8077
mockUser.onGet("http://localhost:3000/api/auth/user").reply(200, authData);
8178

8279
store.commit("auth/authSuccess", authData);
8380
store.commit("auth/changeData", authData);
8481
store.commit("namespaces/setNamespace", namespaceData);
85-
store.commit("security/setSecurity", session);
8682

8783
wrapper = mount(ConnectorForm, {
8884
global: {

ui/tests/components/Namespace/NamespaceEdit.spec.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,6 @@ describe("Namespace Edit", () => {
6363
},
6464
};
6565

66-
const session = true;
67-
6866
beforeEach(async () => {
6967
const el = document.createElement("div");
7068
document.body.appendChild(el);
@@ -76,7 +74,6 @@ describe("Namespace Edit", () => {
7674
mockUser = new MockAdapter(usersApi.getAxios());
7775

7876
mockNamespace.onGet("http://localhost:3000/api/namespaces/fake-tenant-data").reply(200, namespaceData);
79-
mockUser.onGet("http://localhost:3000/api/users/security").reply(200, session);
8077
mockUser.onGet("http://localhost:3000/api/auth/user").reply(200, authData);
8178

8279
wrapper = mount(NamespaceEdit, {
@@ -90,7 +87,6 @@ describe("Namespace Edit", () => {
9087
store.commit("auth/authSuccess", authData);
9188
store.commit("auth/changeData", authData);
9289
store.commit("namespaces/setNamespace", namespaceData);
93-
store.commit("security/setSecurity", session);
9490
});
9591

9692
it("Is a Vue instance", () => {

ui/tests/components/Namespace/NamespaceLeave.spec.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,6 @@ describe("Namespace Leave", () => {
6262
},
6363
};
6464

65-
const session = true;
66-
6765
beforeEach(async () => {
6866
const el = document.createElement("div");
6967
document.body.appendChild(el);
@@ -75,13 +73,11 @@ describe("Namespace Leave", () => {
7573
mockUser = new MockAdapter(usersApi.getAxios());
7674

7775
mockNamespace.onGet("http://localhost:3000/api/namespaces/fake-tenant-data").reply(200, namespaceData);
78-
mockUser.onGet("http://localhost:3000/api/users/security").reply(200, session);
7976
mockUser.onGet("http://localhost:3000/api/auth/user").reply(200, authData);
8077

8178
store.commit("auth/authSuccess", authData);
8279
store.commit("auth/changeData", authData);
8380
store.commit("namespaces/setNamespace", namespaceData);
84-
store.commit("security/setSecurity", session);
8581

8682
wrapper = mount(NamespaceLeave, {
8783
global: {

ui/tests/components/PrivateKeys/PrivateKeyAdd.spec.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,6 @@ describe("Setting Private Keys", () => {
6060
},
6161
};
6262

63-
const session = true;
64-
6563
beforeEach(async () => {
6664
const el = document.createElement("div");
6765
document.body.appendChild(el);
@@ -73,13 +71,11 @@ describe("Setting Private Keys", () => {
7371
mockUser = new MockAdapter(usersApi.getAxios());
7472

7573
mockNamespace.onGet("http://localhost:3000/api/namespaces/fake-tenant-data").reply(200, namespaceData);
76-
mockUser.onGet("http://localhost:3000/api/users/security").reply(200, session);
7774
mockUser.onGet("http://localhost:3000/api/auth/user").reply(200, authData);
7875

7976
store.commit("auth/authSuccess", authData);
8077
store.commit("auth/changeData", authData);
8178
store.commit("namespaces/setNamespace", namespaceData);
82-
store.commit("security/setSecurity", session);
8379
wrapper = mount(PrivateKeyAdd, {
8480
global: {
8581
plugins: [[store, key], vuetify, router, SnackbarPlugin],

ui/tests/components/PrivateKeys/PrivateKeyDelete.spec.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,6 @@ describe("Private Key Delete", () => {
6161
},
6262
};
6363

64-
const session = true;
65-
6664
beforeEach(async () => {
6765
const el = document.createElement("div");
6866
document.body.appendChild(el);
@@ -74,7 +72,6 @@ describe("Private Key Delete", () => {
7472
mockUser = new MockAdapter(usersApi.getAxios());
7573

7674
mockNamespace.onGet("http://localhost:3000/api/namespaces/fake-tenant-data").reply(200, namespaceData);
77-
mockUser.onGet("http://localhost:3000/api/users/security").reply(200, session);
7875
mockUser.onGet("http://localhost:3000/api/auth/user").reply(200, authData);
7976

8077
wrapper = mount(PrivateKeyDelete, {
@@ -91,7 +88,6 @@ describe("Private Key Delete", () => {
9188
store.commit("auth/authSuccess", authData);
9289
store.commit("auth/changeData", authData);
9390
store.commit("namespaces/setNamespace", namespaceData);
94-
store.commit("security/setSecurity", session);
9591
});
9692

9793
it("Is a Vue instance", () => {

ui/tests/components/PrivateKeys/PrivateKeyEdit.spec.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,6 @@ describe("Private Key Edit", () => {
6666
data: "test-data",
6767
};
6868

69-
const session = true;
70-
7169
beforeEach(async () => {
7270
const el = document.createElement("div");
7371
document.body.appendChild(el);
@@ -79,7 +77,6 @@ describe("Private Key Edit", () => {
7977
mockUser = new MockAdapter(usersApi.getAxios());
8078

8179
mockNamespace.onGet("http://localhost:3000/api/namespaces/fake-tenant-data").reply(200, namespaceData);
82-
mockUser.onGet("http://localhost:3000/api/users/security").reply(200, session);
8380
mockUser.onGet("http://localhost:3000/api/auth/user").reply(200, authData);
8481

8582
wrapper = mount(PrivateKeyEdit, {
@@ -96,7 +93,6 @@ describe("Private Key Edit", () => {
9693
store.commit("auth/authSuccess", authData);
9794
store.commit("auth/changeData", authData);
9895
store.commit("namespaces/setNamespace", namespaceData);
99-
store.commit("security/setSecurity", session);
10096
});
10197

10298
it("Is a Vue instance", () => {

0 commit comments

Comments
 (0)