refactor(api,cli): change SystemSet to accept full model

- Change SystemSet signature to receive *models.System instead of (key,
  value)

Author: heiytor

api/services/setup.go

@@ -26,7 +26,8 @@ type SetupService interface {
 }
 
 func (s *service) Setup(ctx context.Context, req requests.Setup) error {
-	if system, err := s.store.SystemGet(ctx); err != nil || system.Setup {
+	system, err := s.store.SystemGet(ctx)
+	if err != nil || system.Setup {
 		return NewErrSetupForbidden(err)
 	}
 
@@ -98,7 +99,8 @@ func (s *service) Setup(ctx context.Context, req requests.Setup) error {
 		return NewErrNamespaceDuplicated(err)
 	}
 
-	if err := s.store.SystemSet(ctx, "setup", true); err != nil { //nolint:revive
+	system.Setup = true
+	if err := s.store.SystemSet(ctx, system); err != nil {
 		return err
 	}
 

api/services/setup_test.go

@@ -302,19 +302,17 @@ func TestSetup(t *testing.T) {
 				Password: "secret",
 			},
 			requiredMocks: func() {
-				storeMock.On("SystemGet", ctx).Return(&models.System{
-					Setup: false,
-				}, nil).Once()
+				initialSystem := &models.System{Setup: false}
+				finalSystem := &models.System{Setup: true}
 
-				clockMock.On("Now").Return(now).Twice()
-				uuidMock := &uuidmock.Uuid{}
-				uuidMock.On("Generate").Return("random_uuid").Once()
+				storeMock.On("SystemGet", ctx).Return(initialSystem, nil).Once()
 
-				hashMock.
-					On("Do", "secret").
+				hashMock.On("Do", "secret").
 					Return("$2a$10$V/6N1wsjheBVvWosPfv02uf4WAOb9lmp8YVVCIa2UYuFV4OJby7Yi", nil).
 					Once()
 
+				clockMock.On("Now").Return(now).Twice()
+
 				user := &models.User{
 					Origin:    models.UserOriginLocal,
 					Status:    models.UserStatusConfirmed,
@@ -356,10 +354,8 @@ func TestSetup(t *testing.T) {
 					},
 					CreatedAt: now,
 				}
-				storeMock.On("UserCreate", ctx, user).Return("000000000000000000000000", nil).Once()
 				storeMock.On("NamespaceCreate", ctx, namespace).Return(tenant, nil).Once()
-
-				storeMock.On("SystemSet", ctx, "setup", true).Return(nil).Once()
+				storeMock.On("SystemSet", ctx, finalSystem).Return(nil).Once()
 			},
 			expected: nil,
 		},

api/store/mocks/store.go

@@ -40,22 +40,15 @@ func (s *Store) SystemGet(ctx context.Context) (*models.System, error) {
 	return system, nil
 }
 
-func (s *Store) SystemSet(ctx context.Context, key string, value any) error {
+func (s *Store) SystemSet(ctx context.Context, system *models.System) error {
 	upsert := true
-
-	_, err := s.db.Collection(SystemCollection).UpdateOne(ctx, bson.M{}, bson.M{
-		"$set": bson.M{
-			key: value,
-		},
-	}, &options.UpdateOptions{
-		Upsert: &upsert,
-	})
+	_, err := s.db.Collection(SystemCollection).UpdateOne(ctx, bson.M{}, bson.M{"$set": system}, &options.UpdateOptions{Upsert: &upsert})
 	if err != nil {
 		return FromMongoError(err)
 	}
 
 	if err := s.cache.Delete(ctx, SystemCollection); err != nil {
-		log.WithField(SystemCollection, key).Warn("failed to delete system from cache")
+		log.WithField("system", system).Warn("failed to delete system from cache")
 	}
 
 	return nil

api/store/mongo/system.go

@@ -8,5 +8,5 @@ import (
 
 type SystemStore interface {
 	SystemGet(ctx context.Context) (*models.System, error)
-	SystemSet(ctx context.Context, key string, value any) error
+	SystemSet(ctx context.Context, system *models.System) error
 }

api/store/system.go

@@ -68,7 +68,13 @@ func (s *service) UserCreate(ctx context.Context, input *inputs.UserCreate) (*mo
 		return nil, ErrCreateNewUser
 	}
 
-	s.store.SystemSet(ctx, "setup", true) //nolint:errcheck
+	system, err := s.store.SystemGet(ctx)
+	if err != nil {
+		system = &models.System{}
+	}
+
+	system.Setup = true
+	_ = s.store.SystemSet(ctx, system)
 
 	return user, nil
 }

cli/services/users.go

@@ -185,8 +185,11 @@ func TestUserCreate(t *testing.T) {
 						AuthMethods: []models.UserAuthMethod{models.UserAuthMethodLocal},
 					},
 				}
+
 				mock.On("UserCreate", ctx, user).Return("000000000000000000000000", nil).Once()
-				mock.On("SystemSet", ctx, "setup", true).Return(nil).Once()
+
+				mock.On("SystemGet", ctx).Return(&models.System{Setup: false}, nil).Once()
+				mock.On("SystemSet", ctx, &models.System{Setup: true}).Return(nil).Once()
 			},
 			expected: Expected{&models.User{
 				Origin: models.UserOriginLocal,