unit tests

Author: brandonocasey

fixtures/async-exit-code.js

@@ -0,0 +1,39 @@
+import process from 'node:process';
+import exitHook, {asyncExitHook, gracefulExit} from '../index.js';
+
+exitHook(() => {
+	console.log('foo');
+});
+
+exitHook(() => {
+	console.log('bar');
+});
+
+const unsubscribe = exitHook(() => {
+	console.log('baz');
+});
+
+unsubscribe();
+
+asyncExitHook(
+	async () => {
+		await new Promise(resolve => {
+			setTimeout(() => {
+				resolve();
+			}, 100);
+		});
+
+		console.log('quux');
+	},
+	{
+		wait: 200,
+	},
+);
+
+process.exitCode = 1;
+
+if (process.env.EXIT_HOOK_SYNC === '1') {
+	process.exit(); // eslint-disable-line unicorn/no-process-exit
+}
+
+gracefulExit();

fixtures/empty-exit-code.js

@@ -0,0 +1,6 @@
+import exitHook from '../index.js';
+
+process.exitCode = 1;
+exitHook(() => {
+	// https://github.com/sindresorhus/exit-hook/issues/23
+});

fixtures/signal-exit-code.js

@@ -0,0 +1,13 @@
+import exitHook, {asyncExitHook} from '../index.js';
+
+exitHook(signal => {
+	console.log(signal);
+});
+
+asyncExitHook(async signal => {
+	console.log(signal);
+}, {
+	wait: 200,
+});
+
+setInterval(() => {}, 1e9);

fixtures/sync-exit-code.js

@@ -0,0 +1,20 @@
+import process from 'node:process';
+import exitHook from '../index.js';
+
+exitHook(() => {
+	console.log('foo');
+});
+
+exitHook(() => {
+	console.log('bar');
+});
+
+const unsubscribe = exitHook(() => {
+	console.log('baz');
+});
+
+unsubscribe();
+
+process.exitCode = 1;
+
+process.exit(); // eslint-disable-line unicorn/no-process-exit

index.js

@@ -23,7 +23,7 @@ async function exit(shouldManuallyExit, isSynchronous, signal) {
 		].join(' '));
 	}
 
-	const exitCode = (typeof process.exitCode === 'number') ? process.exitCode : 128 + signal;
+	const exitCode = (typeof process.exitCode === 'number' || typeof process.exitCode === 'string') ? process.exitCode : 128 + signal;
 
 	const done = (force = false) => {
 		if (force === true || shouldManuallyExit === true) {

test.js

@@ -10,19 +10,52 @@ test('main', async t => {
 	t.is(exitCode, 0);
 });
 
+test('main with exitCode', async t => {
+	try {
+		await execa(process.execPath, ['./fixtures/sync-exit-code.js']);
+		t.fail();
+	} catch ({stdout, stderr, exitCode}) {
+		t.is(stdout, 'foo\nbar');
+		t.is(stderr, '');
+		t.is(exitCode, 1);
+	}
+});
+
 test('main-empty', async t => {
 	const {stderr, exitCode} = await execa(process.execPath, ['./fixtures/empty.js']);
 	t.is(stderr, '');
 	t.is(exitCode, 0);
 });
 
+test('main-empty with exitCode', async t => {
+	try {
+		await execa(process.execPath, ['./fixtures/empty-exit-code.js']);
+		t.fail();
+	} catch ({stdout, stderr, exitCode}) {
+		t.is(stdout, '');
+		t.is(stderr, '');
+		t.is(exitCode, 1);
+	}
+});
+
 test('main-async', async t => {
 	const {stdout, stderr, exitCode} = await execa(process.execPath, ['./fixtures/async.js']);
 	t.is(stdout, 'foo\nbar\nquux');
 	t.is(stderr, '');
 	t.is(exitCode, 0);
 });
 
+test('main-async with exitCode', async t => {
+	try {
+		await execa(process.execPath, ['./fixtures/async-exit-code.js']);
+		t.fail();
+	} catch ({stdout, stderr, exitCode}) {
+		t.is(stdout, 'foo\nbar\nquux');
+		t.is(stderr, '');
+		t.is(exitCode, 1);
+	}
+});
+
 test('main-async-notice', async t => {
 	const {stdout, stderr, exitCode} = await execa(process.execPath, ['./fixtures/async.js'], {
 		env: {
@@ -34,11 +67,27 @@ test('main-async-notice', async t => {
 	t.is(exitCode, 0);
 });
 
+test('main-async-notice with exitCode', async t => {
+	try {
+		await execa(process.execPath, ['./fixtures/async-exit-code.js'], {
+			env: {
+				EXIT_HOOK_SYNC: '1',
+			},
+		});
+		t.fail();
+	} catch ({stdout, stderr, exitCode}) {
+		t.is(stdout, 'foo\nbar');
+		t.regex(stderr, /SYNCHRONOUS TERMINATION NOTICE/);
+		t.is(exitCode, 1);
+	}
+});
+
 test('listener count', t => {
+	console.log(process.listeners('exit')[0].toString())
 	t.is(process.listenerCount('exit'), 0);
 
-	const unsubscribe1 = exitHook(() => {});
-	const unsubscribe2 = exitHook(() => {});
+	const unsubscribe1 = exitHook(() => { });
+	const unsubscribe2 = exitHook(() => { });
 	t.is(process.listenerCount('exit'), 1);
 
 	// Remove all listeners
@@ -47,7 +96,7 @@ test('listener count', t => {
 	t.is(process.listenerCount('exit'), 1);
 
 	// Re-add listener
-	const unsubscribe3 = exitHook(() => {});
+	const unsubscribe3 = exitHook(() => { });
 	t.is(process.listenerCount('exit'), 1);
 
 	// Remove again
@@ -56,7 +105,7 @@ test('listener count', t => {
 
 	// Add async style listener
 	const unsubscribe4 = asyncExitHook(
-		async () => {},
+		async () => { },
 		{
 			wait: 100,
 		},