Skip to content

Commit 78d6259

Browse files
authored
Node 20 & dependencies upgrade (#165)
* Upgrade to node 20, package updates, fix some vulnerabilities * husky changes * smaller pkg updates
1 parent f740c6b commit 78d6259

File tree

7 files changed

+926
-919
lines changed

7 files changed

+926
-919
lines changed

.github/workflows/docker.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
docker:
1010
runs-on: ubuntu-latest
1111
steps:
12-
- uses: actions/checkout@v2
12+
- uses: actions/checkout@v4
1313
- name: Login to DockerHub
1414
uses: docker/login-action@v1
1515
with:

.github/workflows/test.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@ jobs:
99
runs-on: ubuntu-latest
1010

1111
steps:
12-
- uses: actions/checkout@v2
13-
- uses: actions/setup-node@v2
12+
- uses: actions/checkout@v4
13+
- uses: actions/setup-node@v4
1414
with:
15-
node-version: "15"
15+
node-version: "20"
1616
- run: yarn install --frozen-lockfile
1717
- run: yarn test
1818
- run: yarn run lint

.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ node_modules
3838

3939
#editor stuff
4040
.lvimrc
41+
.idea
4142

4243
#Elm
4344
elm-stuff
@@ -47,4 +48,4 @@ src/public/*
4748
!src/public/index.html
4849

4950
.env
50-
.DS_Store
51+
.DS_Store

.husky/pre-commit

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
#!/bin/sh
2+
3+
pretty-quick --staged && yarn lint && yarn test

Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
FROM node:14-alpine as build
1+
FROM node:20-alpine as build
22
WORKDIR /www
33
COPY package.json yarn.lock ./
44
RUN yarn install --production --frozen-lockfile
55
COPY . /www/
66

7-
FROM node:14-alpine as release
7+
FROM node:20-alpine as release
88
RUN apk --no-cache add tini
99
ENTRYPOINT ["tini", "--"]
1010
USER node

package.json

Lines changed: 18 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@
1212
"test:debug": "node --inspect-brk ./node_modules/jest/bin/jest.js --runInBand",
1313
"lint": "eslint src",
1414
"format": "prettier --write .",
15-
"start": "node src/web-server.js"
15+
"start": "node src/web-server.js",
16+
"prepare": "husky"
1617
},
1718
"repository": {
1819
"type": "git",
@@ -24,42 +25,38 @@
2425
"author": "nhumrich",
2526
"license": "Apache-2.0",
2627
"engines": {
27-
"node": ">=14.0.0"
28+
"node": ">=20.0.0"
2829
},
30+
"packageManager": "[email protected]",
2931
"bugs": {
3032
"url": "https://github.com/single-spa/import-map-deployer/issues"
3133
},
32-
"husky": {
33-
"hooks": {
34-
"pre-commit": "pretty-quick --staged && yarn lint && yarn test"
35-
}
36-
},
3734
"homepage": "https://github.com/single-spa/import-map-deployer#readme",
3835
"dependencies": {
3936
"@azure/storage-blob": "^12.1.2",
40-
"@google-cloud/storage": "^5.7.4",
37+
"@google-cloud/storage": "^6.12.0",
4138
"aws-sdk": "^2.2.27",
42-
"basic-auth": "^1.0.3",
43-
"body-parser": "^1.14.2",
44-
"dotenv": "^8.2.0",
45-
"express": "^4.13.3",
46-
"lodash": "^4.17.11",
47-
"minimist": "^1.2.0",
48-
"morgan": "^1.8.1",
49-
"request": "^2.79.0",
39+
"basic-auth": "^1.1.0",
40+
"body-parser": "^1.20.2",
41+
"dotenv": "^8.6.0",
42+
"express": "^4.19.2",
43+
"lodash": "^4.17.21",
44+
"minimist": "^1.2.8",
45+
"morgan": "^1.10.0",
46+
"request": "^2.88.2",
5047
"rwlock": "^5.0.0"
5148
},
5249
"devDependencies": {
53-
"eslint": "^7.2.0",
54-
"eslint-config-node-important-stuff": "^1.0.0",
50+
"eslint": "^7.32.0",
51+
"eslint-config-node-important-stuff": "^1.1.0",
5552
"eslint-config-prettier": "^6.11.0",
5653
"eslint-plugin-prettier": "^3.1.3",
57-
"husky": "^4.2.5",
54+
"husky": "^9.1.5",
5855
"jest": "^26.0.1",
5956
"jest-cli": "^26.0.1",
6057
"prettier": "^2.0.4",
61-
"pretty-quick": "^2.0.1",
62-
"supertest": "^4.0.2"
58+
"pretty-quick": "^2.0.2",
59+
"supertest": "^6.3.4"
6360
},
6461
"publishConfig": {
6562
"registry": "https://registry.npmjs.org"

0 commit comments

Comments
 (0)