Old Modernizr release 3.5.0 used in repository

[stweil]

The source code contains the file Resources/Private/JavaScript/modernizrCustom.js which includes a comment "modernizr 3.5.0 (Custom Build)". This file causes a note from GitHub's code scanning:

Some statements in JavaScript do not have to be terminated by an explicit semicolon; the parser will implicitly insert a semicolon when it encounters a newline character in such situations. This is a dangerous feature since it can mask subtle errors and confuse readers; it should not be relied on.

The mentioned release 3.5.0 is from Apr 20, 2017, so maybe it should be replaced by a newer release. It would also be nice to mention external code like Modernizr in the README. Maybe it is even required to include the copyright notice of Modernizr to comply with its license.

[stweil]

AI suggests to replace the dependency on Modernizr with a modified function mobileCheck:

    function mobileCheck() {
        return 'ontouchstart' in window || navigator.maxTouchPoints; // Check for touch support
    }
[...]
    // Complex page turning mechanism and check if a click on page control was made and unfold next/back navigation
    if (mobileCheck()) { // Replaced Modernizr.touchevents with mobileCheck()

This might eliminate the need for Modernizr, thus reducing the code size and solving this issue.

[stweil]

See also this discussion.