fix: Handle multiple exports from the same file in fs-router (#1936)

Author: dennev

.changeset/sharp-rooms-think.md

@@ -0,0 +1,5 @@
+---
+"@solidjs/start": patch
+---
+
+Handle multiple exports from the same file in fs-router

.changeset/ten-areas-burn.md

@@ -0,0 +1,5 @@
+---
+"@solidjs/start": patch
+---
+
+Add a test route for multiple exports handling and correct variable typos

packages/start/config/fs-router.js

@@ -1,4 +1,4 @@
-import { analyzeModule, BaseFileSystemRouter, cleanPath } from "vinxi/fs-router";
+import {analyzeModule, BaseFileSystemRouter, cleanPath} from "vinxi/fs-router";
 
 export class SolidStartClientFileRouter extends BaseFileSystemRouter {
   toPath(src) {
@@ -43,13 +43,13 @@ export class SolidStartClientFileRouter extends BaseFileSystemRouter {
         page: true,
         $component: {
           src: src,
-          pick: ["default", "$css"]
+          pick: [...exports.filter(e => e.n === e.ln && e.n !== "route").map(e => e.n), "default", "$css"]
         },
         $$route: hasRouteConfig
           ? {
-              src: src,
-              pick: ["route"]
-            }
+            src: src,
+            pick: ["route"]
+          }
           : undefined,
         path,
         filePath: src
@@ -123,15 +123,15 @@ export class SolidStartServerFileRouter extends BaseFileSystemRouter {
         $component:
           !this.config.dataOnly && hasDefault
             ? {
-                src: src,
-                pick: ["default", "$css"]
-              }
+              src: src,
+              pick: [...exports.filter(e => e.n === e.ln && e.n !== "route" && !HTTP_METHODS.includes(e.n)).map(e => e.n), "default", "$css"]
+            }
             : undefined,
         $$route: hasRouteConfig
           ? {
-              src: src,
-              pick: ["route"]
-            }
+            src: src,
+            pick: ["route"]
+          }
           : undefined,
         ...createHTTPHandlers(src, exports),
         path,

packages/tests/src/app.tsx

@@ -50,6 +50,9 @@ export default function App() {
             <li>
               <a href="/generator-server-function">generator server function</a>
             </li>
+            <li>
+              <a href="/referencing-multiple-export-named-functions-in-the-same-file">referencing multiple export named functions in the same file</a>
+            </li>
           </ul>
           <Suspense>{props.children}</Suspense>
         </MetaProvider>

packages/tests/src/functions/text-render-test-component.tsx

@@ -0,0 +1,4 @@
+export function TextRenderTestComponent() {
+  const text = "(´｡> ᵕ <｡`) ♡";
+  return <>{text}</>;
+}

packages/tests/src/routes/is-server-const.tsx

@@ -6,8 +6,8 @@ export default function App() {
 
 
     createEffect(async () => {
-        const restult = await serverFnWithIsServer();
-        setOutput(prev => ({ ...prev, serverFnWithIsServer: restult }));
+        const result = await serverFnWithIsServer();
+        setOutput(prev => ({ ...prev, serverFnWithIsServer: result }));
     });
 
 

packages/tests/src/routes/is-server-nested.tsx

@@ -12,8 +12,8 @@ export default function App() {
 
 
   createEffect(async () => {
-    const restult = await serverFnWithIsServer();
-    setOutput(prev => ({ ...prev, serverFnWithIsServer: restult }));
+    const result = await serverFnWithIsServer();
+    setOutput(prev => ({ ...prev, serverFnWithIsServer: result }));
   });
 
 

packages/tests/src/routes/is-server-toplevel.tsx

@@ -6,8 +6,8 @@ export default function App() {
 
 
   createEffect(async () => {
-    const restult = await serverFnWithIsServer();
-    setOutput(prev => ({ ...prev, serverFnWithIsServer: restult }));
+    const result = await serverFnWithIsServer();
+    setOutput(prev => ({ ...prev, serverFnWithIsServer: result }));
   });
 
 

packages/tests/src/routes/is-server-with-anon-default-export.tsx

@@ -6,8 +6,8 @@ export default function App() {
 
 
     createEffect(async () => {
-        const restult = await serverFnWithIsServer();
-        setOutput(prev => ({ ...prev, serverFnWithIsServer: restult }));
+        const result = await serverFnWithIsServer();
+        setOutput(prev => ({ ...prev, serverFnWithIsServer: result }));
     });
 
 

packages/tests/src/routes/node-builtin-nested.tsx

@@ -13,8 +13,8 @@ export default function App() {
 
 
   createEffect(async () => {
-    const restult = await serverFnWithNodeBuiltin();
-    setOutput(prev => ({ ...prev, serverFnWithNodeBuiltin: restult }));
+    const result = await serverFnWithNodeBuiltin();
+    setOutput(prev => ({ ...prev, serverFnWithNodeBuiltin: result }));
   });
 
   return (