Check Screen Version fails on MacOS

[williamjulianvicary]

This is related to PR #81 and with a MacOS device.

On this line:
https://github.com/soloterm/solo/blob/main/src/Console/Commands/Solo.php#L41

the screen -v command on Mac returns the exit code 1, ->isSuccessful is only checking for exit code === 0 so it's filling up the error log with the "unable to determine screen version".

Separately, my screen version is 4.x, not 5.x - if we're expecting users to bump versions to 5.x manually (as mine is stock latest MacOS) and otherwise send an error log then I'd propose adding something to the readme to that effect. OR, reduce the compatibility check to < 4.0.0?

Also, given this isn't actually an error, would a Log::warn or even Log::info make more sense here?

Happy to add a PR if I can get some thoughts on the above?

[mortenscheel]

Expecting screen v5 is a pretty big ask, since v4 is the version provided by both homebrew and all the linux package managers I've tried (latest ubuntu, debian and alma).

I went so far as to build it from source, but I didn't really notice any difference, except that those log messages stopped. Maybe explain why v5 is necessary? But definitely stop spamming the logs.

[jackwh]

brew install screen provides v5.0.1 on macOS now, FYI.