Skip to content

Conversation

@move-hoon
Copy link
Member

Related issue 🛠

Work Description ✏️

  • JsonNode 로깅을 추가했습니다.

Trouble Shooting ⚽️

  • None

@move-hoon move-hoon self-assigned this Apr 23, 2025
@move-hoon move-hoon linked an issue Apr 23, 2025 that may be closed by this pull request
1 task
@height
Copy link

height bot commented Apr 23, 2025

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@coderabbitai
Copy link

coderabbitai bot commented Apr 23, 2025

Summary by CodeRabbit

  • 버그 수정
    • 이벤트 추출 과정에서 수신된 JSON 데이터의 구조를 로그로 출력하여 진단 및 문제 해결이 용이해졌습니다.

Walkthrough

이 변경사항은 extractSentryEvent 메서드 내부에 info 레벨의 로그를 두 군데 추가하여, 파싱된 JSON의 루트 노드와 이벤트 노드의 내용을 출력하도록 했습니다. 기존의 로직이나 제어 흐름에는 영향을 주지 않으면서, 요청 본문에서 수신한 JSON 구조를 더 명확히 파악할 수 있도록 가시성을 높였습니다.

Changes

파일/경로 변경 요약
src/main/java/org/sopt/makers/handler/SentryWebhookHandler.java extractSentryEvent 내 JsonNode info 레벨 로깅 추가

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant SentryWebhookHandler

    Client->>SentryWebhookHandler: HTTP Request (JSON Body)
    SentryWebhookHandler->>SentryWebhookHandler: extractSentryEvent()
    SentryWebhookHandler->>SentryWebhookHandler: Log root JsonNode
    SentryWebhookHandler->>SentryWebhookHandler: Log event JsonNode
    SentryWebhookHandler-->>Client: (기존 로직 계속 진행)
Loading

Assessment against linked issues

Objective Addressed Explanation
JsonNode 로깅을 추가 (#15)

Suggested labels

size/XS

Poem

로그를 남기며 깡총깡총
JSON 구조를 밝히는 내 솜털 송송
루트와 이벤트, 모두 다 보여주니
디버깅의 길에 햇살이 비치니
깡총이 개발자, 오늘도 신나네! 🐰

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/main/java/org/sopt/makers/handler/SentryWebhookHandler.java (1)

79-81: 로깅 추가에 대한 검토

로그 추가를 통해 디버깅과 모니터링 가시성이 향상되었습니다. 하지만 몇 가지 고려해야 할 사항이 있습니다:

  1. 대용량 JSON 객체를 로깅할 때 성능 영향을 고려해보세요.
  2. 민감한 정보가 포함될 수 있으므로 보안 측면에서 전체 JSON 노드를 로깅하는 것이 적절한지 검토하세요.
  3. 일반 운영에서는 info 대신 debug 레벨이 더 적합할 수 있습니다.
- log.info("rootNode 정보: {}", rootNode);
- log.info("eventNode 정보: {}", eventNode);
+ log.debug("Sentry 웹훅 요청 본문: {}", rootNode);
+ log.debug("추출된 Sentry 이벤트: {}", eventNode);

또는 민감한 정보 필터링을 고려한다면:

// 중요 필드만 선택적으로 로깅
log.info("Sentry 이벤트 정보: id={}, project={}", 
    eventNode.path("id").asText("없음"), 
    eventNode.path("project").asText("없음"));
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ee61660 and 36e9a0a.

📒 Files selected for processing (1)
  • src/main/java/org/sopt/makers/handler/SentryWebhookHandler.java (1 hunks)

@move-hoon move-hoon merged commit ae9bea1 into main Apr 23, 2025
2 checks passed
@move-hoon move-hoon deleted the chore/#15 branch May 12, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: JsonNode 로깅 추가

2 participants