-
Notifications
You must be signed in to change notification settings - Fork 1
chore: JsonNode 로깅 추가 완료 #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Summary by CodeRabbit
Walkthrough이 변경사항은 Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant SentryWebhookHandler
Client->>SentryWebhookHandler: HTTP Request (JSON Body)
SentryWebhookHandler->>SentryWebhookHandler: extractSentryEvent()
SentryWebhookHandler->>SentryWebhookHandler: Log root JsonNode
SentryWebhookHandler->>SentryWebhookHandler: Log event JsonNode
SentryWebhookHandler-->>Client: (기존 로직 계속 진행)
Assessment against linked issues
Suggested labels
Poem
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/main/java/org/sopt/makers/handler/SentryWebhookHandler.java (1)
79-81: 로깅 추가에 대한 검토로그 추가를 통해 디버깅과 모니터링 가시성이 향상되었습니다. 하지만 몇 가지 고려해야 할 사항이 있습니다:
- 대용량 JSON 객체를 로깅할 때 성능 영향을 고려해보세요.
- 민감한 정보가 포함될 수 있으므로 보안 측면에서 전체 JSON 노드를 로깅하는 것이 적절한지 검토하세요.
- 일반 운영에서는
info대신debug레벨이 더 적합할 수 있습니다.- log.info("rootNode 정보: {}", rootNode); - log.info("eventNode 정보: {}", eventNode); + log.debug("Sentry 웹훅 요청 본문: {}", rootNode); + log.debug("추출된 Sentry 이벤트: {}", eventNode);또는 민감한 정보 필터링을 고려한다면:
// 중요 필드만 선택적으로 로깅 log.info("Sentry 이벤트 정보: id={}, project={}", eventNode.path("id").asText("없음"), eventNode.path("project").asText("없음"));
Related issue 🛠
Work Description ✏️
Trouble Shooting ⚽️