Skip to content

If descent is zero, cufon returns empty string instead of zero for descent. #276

@tmccombs

Description

@tmccombs

If the descent of a font is 0, then cufon sets the descent to "" in the response JSON.

This is caused by a combination of initially setting the descent to "" in the $currentFace (line 119 of SVGFont.php) and comparing $actualValue to null with == instead of === on line 178 of SVGFont.php. In php 0 == null returns true.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions