Skip to content

Commit fb73323

Browse files
committed
Bug fix when delating with 0 data for day data downlloader
1 parent 141eadd commit fb73323

File tree

2 files changed

+32
-26
lines changed

2 files changed

+32
-26
lines changed

kubernetes/pod.yaml

Lines changed: 28 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,32 @@
1-
apiVersion: v1
2-
kind: Pod
1+
apiVersion: batch/v1
2+
kind: CronJob
33
metadata:
44
name: data-downloader-pod
55
namespace: equitian-app
66
spec:
7-
imagePullSecrets:
8-
- name: regcred
9-
containers:
10-
- name: data-downloader-container
11-
image: docker.pkg.github.com/source-nerd/yahoo-data-downloader-docker-elastic/yahoo-data-downloader-docker-elastic:0.1
12-
env:
13-
- name: ES_HOST
14-
value: ES_HOST
15-
- name: ES_PORT
16-
value: "9200"
17-
- name: ES_USERNAME
18-
value: "elastic"
19-
- name: ES_PASSWORD
20-
value: ES_PASSWORD
21-
- name: INDEX_1_MIN
22-
value: INDEX_1_MIN
23-
- name: INDEX_1_DAY
24-
value: INDEX_1_DAY
25-
- name: STOCKS
26-
value: "AAPL,TSLA,MSFT"
27-
restartPolicy: OnFailure
7+
schedule: "30 20 * * 1,2,3,4,5"
8+
jobTemplate:
9+
spec:
10+
template:
11+
spec:
12+
imagePullSecrets:
13+
- name: regcred
14+
containers:
15+
- name: data-downloader-container
16+
image: docker.pkg.github.com/source-nerd/yahoo-data-downloader-docker-elastic/yahoo-data-downloader-docker-elastic:0.1
17+
env:
18+
- name: ES_HOST
19+
value: "elasticsearch.NAMESPACE.svc.cluster.local"
20+
- name: ES_PORT
21+
value: "9200"
22+
- name: ES_USERNAME
23+
value: "elastic"
24+
- name: ES_PASSWORD
25+
value: "ES_PASSWORD"
26+
- name: INDEX_1_MIN
27+
value: "INDEX_1_MIN"
28+
- name: INDEX_1_DAY
29+
value: "INDEX_1_DAY"
30+
- name: STOCKS
31+
value: "AAPL,AMZN,AMD,FB,FISV,GS,GOOGL,INTC,MCD,MSFT,NVDA,PG,TSLA,V"
32+
restartPolicy: OnFailure

us_data_downloader.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,10 @@ def day_downloader_main():
9191

9292
for item in STOCKS_LIST:
9393
res_data = download_1d_data(item, today_date, today_date)
94-
helpers.bulk(
95-
es_client, doc_generator(res_data, item, "Date", INDEX_1_DAY)
96-
)
94+
if res_data.shape[0] > 0:
95+
helpers.bulk(
96+
es_client, doc_generator(res_data, item, "Date", INDEX_1_DAY)
97+
)
9798
LOGGER.info(f"Done downloading data for - [{today_date}]")
9899

99100

0 commit comments

Comments
 (0)