From 0593d762f5cf2f12b38b97de09998db43a55d7a6 Mon Sep 17 00:00:00 2001 From: slarticodefast <161409025+slarticodefast@users.noreply.github.com> Date: Sat, 18 Apr 2026 20:07:29 +0200 Subject: [PATCH 1/3] Update pull request guidelines to address PR size --- .../codebase-info/pull-request-guidelines.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/en/general-development/codebase-info/pull-request-guidelines.md b/src/en/general-development/codebase-info/pull-request-guidelines.md index bbfa0327b6..d236fc471e 100644 --- a/src/en/general-development/codebase-info/pull-request-guidelines.md +++ b/src/en/general-development/codebase-info/pull-request-guidelines.md @@ -17,6 +17,8 @@ Your pull request may be reverted or closed for any reason. - Large new features and comprehensive reworks to existing large features (ie antags or anything that could be considered a subdepartment unto itself), should first be [proposed and accepted in abstract](../feature-proposals.md) before you start working on actually implementing it. +- Don't make make giant PRs containing several thousand lines of code. Instead split them up into smaller parts, especially for major new features like antagonists or game modes. Implementing them one step at a time makes them much easier to review. On the other hand if your PR is too large it is very likely that it will not receive any reviews because reviewing it all at once is simply not feasible or would take multiple days of maintainer time. If want to start working on a larger project and are unsure where to start, best to talk to a maintainer beforehand. + - Read the [Freezes and Restrictions issue](https://github.com/space-wizards/space-station-14/issues/8524) and make sure your PR does not interfere with anything or requires special requirements. - If you are fixing a bug that is present on the live servers, or addressing an urgent balance issue on the live servers, consider if your change should be a hotfix. From bc3634b0b72b4c5fa1c143b868623b2d6f599ca4 Mon Sep 17 00:00:00 2001 From: slarticodefast <161409025+slarticodefast@users.noreply.github.com> Date: Sat, 18 Apr 2026 21:24:44 +0200 Subject: [PATCH 2/3] typo --- .../codebase-info/pull-request-guidelines.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/en/general-development/codebase-info/pull-request-guidelines.md b/src/en/general-development/codebase-info/pull-request-guidelines.md index d236fc471e..fc009a209a 100644 --- a/src/en/general-development/codebase-info/pull-request-guidelines.md +++ b/src/en/general-development/codebase-info/pull-request-guidelines.md @@ -17,7 +17,7 @@ Your pull request may be reverted or closed for any reason. - Large new features and comprehensive reworks to existing large features (ie antags or anything that could be considered a subdepartment unto itself), should first be [proposed and accepted in abstract](../feature-proposals.md) before you start working on actually implementing it. -- Don't make make giant PRs containing several thousand lines of code. Instead split them up into smaller parts, especially for major new features like antagonists or game modes. Implementing them one step at a time makes them much easier to review. On the other hand if your PR is too large it is very likely that it will not receive any reviews because reviewing it all at once is simply not feasible or would take multiple days of maintainer time. If want to start working on a larger project and are unsure where to start, best to talk to a maintainer beforehand. +- Don't make make giant PRs containing several thousand lines of code. Instead split them up into smaller parts, especially for major new features like antagonists or game modes. Implementing them one step at a time makes them much easier to review. On the other hand if your PR is too large it is very likely that it will not receive any reviews because reviewing it all at once is simply not feasible or would take multiple days of maintainer time. If you want to start working on a larger project and are unsure where to start, best to talk to a maintainer beforehand. - Read the [Freezes and Restrictions issue](https://github.com/space-wizards/space-station-14/issues/8524) and make sure your PR does not interfere with anything or requires special requirements. From bf8c24473600ae3cf9cdc51ad27ad4421194e519 Mon Sep 17 00:00:00 2001 From: slarticodefast <161409025+slarticodefast@users.noreply.github.com> Date: Sat, 18 Apr 2026 21:25:20 +0200 Subject: [PATCH 3/3] rewrite --- .../codebase-info/pull-request-guidelines.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/en/general-development/codebase-info/pull-request-guidelines.md b/src/en/general-development/codebase-info/pull-request-guidelines.md index fc009a209a..424c83aa56 100644 --- a/src/en/general-development/codebase-info/pull-request-guidelines.md +++ b/src/en/general-development/codebase-info/pull-request-guidelines.md @@ -17,7 +17,7 @@ Your pull request may be reverted or closed for any reason. - Large new features and comprehensive reworks to existing large features (ie antags or anything that could be considered a subdepartment unto itself), should first be [proposed and accepted in abstract](../feature-proposals.md) before you start working on actually implementing it. -- Don't make make giant PRs containing several thousand lines of code. Instead split them up into smaller parts, especially for major new features like antagonists or game modes. Implementing them one step at a time makes them much easier to review. On the other hand if your PR is too large it is very likely that it will not receive any reviews because reviewing it all at once is simply not feasible or would take multiple days of maintainer time. If you want to start working on a larger project and are unsure where to start, best to talk to a maintainer beforehand. +- Don't make make giant PRs containing several thousand lines of code. Instead split them up into smaller parts, especially for major new features like antagonists or game modes. Implementing them one step at a time makes them much easier to review. On the other hand if your PR is too large it is very likely that it will not receive any reviews because reviewing it all at once is simply not feasible or would take multiple days of maintainer time. If you want to work on a larger project and are unsure where to start, best to talk to a maintainer beforehand. - Read the [Freezes and Restrictions issue](https://github.com/space-wizards/space-station-14/issues/8524) and make sure your PR does not interfere with anything or requires special requirements.