Skip to content

Commit 93a3511

Browse files
committed
Revert "Merge branch '3.5.x'"
This reverts commit 001f953, reversing changes made to 0ae8693. See gh-48059
2 parents 001f953 + c7c0d33 commit 93a3511

File tree

2 files changed

+2
-13
lines changed

2 files changed

+2
-13
lines changed

module/spring-boot-reactor-netty/src/main/java/org/springframework/boot/reactor/netty/NettyWebServer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ public void start() throws WebServerException {
121121
catch (Exception ex) {
122122
PortInUseException.ifCausedBy(ex, ChannelBindException.class, (bindException) -> {
123123
if (bindException.localPort() > 0 && !isPermissionDenied(bindException.getCause())) {
124-
PortInUseException.throwIfPortBindingException(bindException, bindException::localPort);
124+
throw new PortInUseException(bindException.localPort(), ex);
125125
}
126126
});
127127
throw new WebServerException("Unable to start Netty", ex);

module/spring-boot-reactor-netty/src/test/java/org/springframework/boot/reactor/netty/NettyReactiveWebServerFactoryTests.java

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@
1717
package org.springframework.boot.reactor.netty;
1818

1919
import java.net.ConnectException;
20-
import java.net.InetAddress;
2120
import java.net.SocketAddress;
22-
import java.net.UnknownHostException;
2321
import java.time.Duration;
2422
import java.util.Arrays;
2523

@@ -46,7 +44,6 @@
4644
import org.springframework.boot.web.server.PortInUseException;
4745
import org.springframework.boot.web.server.Shutdown;
4846
import org.springframework.boot.web.server.Ssl;
49-
import org.springframework.boot.web.server.WebServerException;
5047
import org.springframework.boot.web.server.reactive.AbstractReactiveWebServerFactory;
5148
import org.springframework.boot.web.server.reactive.AbstractReactiveWebServerFactoryTests;
5249
import org.springframework.boot.web.server.reactive.ConfigurableReactiveWebServerFactory;
@@ -75,7 +72,7 @@
7572
class NettyReactiveWebServerFactoryTests extends AbstractReactiveWebServerFactoryTests {
7673

7774
@Test
78-
void portInUseExceptionIsThrownWhenPortIsAlreadyInUse() {
75+
void exceptionIsThrownWhenPortIsAlreadyInUse() {
7976
AbstractReactiveWebServerFactory factory = getFactory();
8077
factory.setPort(0);
8178
this.webServer = factory.getWebServer(new EchoHandler());
@@ -86,14 +83,6 @@ void portInUseExceptionIsThrownWhenPortIsAlreadyInUse() {
8683
.withCauseInstanceOf(Throwable.class);
8784
}
8885

89-
@Test
90-
void webServerExceptionIsThrownWhenAddressCannotBeAssigned() throws UnknownHostException {
91-
AbstractReactiveWebServerFactory factory = getFactory();
92-
factory.setPort(8080);
93-
factory.setAddress(InetAddress.getByName("1.2.3.4"));
94-
assertThatExceptionOfType(WebServerException.class).isThrownBy(factory.getWebServer(new EchoHandler())::start);
95-
}
96-
9786
@Test
9887
void getPortWhenDisposableServerPortOperationIsUnsupportedReturnsMinusOne() {
9988
NettyReactiveWebServerFactory factory = new NoPortNettyReactiveWebServerFactory(0);

0 commit comments

Comments
 (0)