starknet_api: add proof fact struct (#10655)

Author: avivg-starkware

crates/apollo_protobuf/src/converters/transaction.rs

@@ -21,6 +21,7 @@ use starknet_api::transaction::fields::{
     ContractAddressSalt,
     Fee,
     PaymasterData,
+    ProofFacts,
     ResourceBounds,
     Tip,
     TransactionSignature,
@@ -649,7 +650,7 @@ impl TryFrom<protobuf::InvokeV3> for InvokeTransactionV3 {
             account_deployment_data,
             // TODO(AvivG): Get proof_facts from P2P protocol, until then, lost during protobuf
             // serialization/deserialization.
-            proof_facts: vec![],
+            proof_facts: ProofFacts::default(),
         })
     }
 }

crates/apollo_protobuf/src/converters/transaction_test.rs

@@ -3,7 +3,12 @@ use lazy_static::lazy_static;
 use rand::random;
 use starknet_api::block::GasPrice;
 use starknet_api::execution_resources::{Builtin, ExecutionResources, GasAmount, GasVector};
-use starknet_api::transaction::fields::{AllResourceBounds, ResourceBounds, ValidResourceBounds};
+use starknet_api::transaction::fields::{
+    AllResourceBounds,
+    ProofFacts,
+    ResourceBounds,
+    ValidResourceBounds,
+};
 use starknet_api::transaction::{
     DeclareTransaction,
     DeclareTransactionOutput,
@@ -122,7 +127,7 @@ fn convert_invoke_transaction_v3_to_vec_u8_and_back() {
         starknet_api::transaction::InvokeTransactionV3::get_test_instance(&mut rng);
     transaction.resource_bounds = *RESOURCE_BOUNDS_MAPPING;
     // TODO(AvivG): Remove this once proof_facts is added to P2P protocol.
-    transaction.proof_facts = vec![];
+    transaction.proof_facts = ProofFacts::default();
     let transaction = StarknetApiTransaction::Invoke(InvokeTransaction::V3(transaction));
 
     let transaction_output = create_transaction_output!(InvokeTransactionOutput, Invoke);

crates/apollo_rpc/src/v0_8/api/mod.rs

@@ -619,6 +619,7 @@ impl From<InvokeTransaction> for starknet_api::transaction::InvokeTransaction {
                 account_deployment_data,
                 nonce_data_availability_mode,
                 fee_data_availability_mode,
+                proof_facts,
             }) => Self::V3(starknet_api::transaction::InvokeTransactionV3 {
                 resource_bounds: resource_bounds.into(),
                 tip,
@@ -630,8 +631,7 @@ impl From<InvokeTransaction> for starknet_api::transaction::InvokeTransaction {
                 fee_data_availability_mode,
                 paymaster_data,
                 account_deployment_data,
-                // TODO(AvivG): Get proof facts from rpc_v8 once supported.
-                proof_facts: vec![],
+                proof_facts,
             }),
         }
     }

crates/apollo_rpc/src/v0_8/transaction.rs

@@ -35,6 +35,7 @@ use starknet_api::transaction::fields::{
     ContractAddressSalt,
     Fee,
     PaymasterData,
+    ProofFacts,
     Resource,
     ResourceBounds,
     Tip,
@@ -447,7 +448,7 @@ pub struct InvokeTransactionV3 {
     pub account_deployment_data: AccountDeploymentData,
     pub nonce_data_availability_mode: DataAvailabilityMode,
     pub fee_data_availability_mode: DataAvailabilityMode,
-    // TODO(AvivG): Add proof facts to rpc_v8.
+    pub proof_facts: ProofFacts,
 }
 
 impl From<InvokeTransactionV3> for client_transaction::InvokeTransaction {
@@ -537,7 +538,7 @@ impl TryFrom<starknet_api::transaction::InvokeTransaction> for InvokeTransaction
                     fee_data_availability_mode,
                     paymaster_data,
                     account_deployment_data,
-                    proof_facts: _,
+                    proof_facts,
                 },
             ) => Ok(Self::Version3(InvokeTransactionV3 {
                 sender_address,
@@ -551,6 +552,7 @@ impl TryFrom<starknet_api::transaction::InvokeTransaction> for InvokeTransaction
                 fee_data_availability_mode,
                 paymaster_data,
                 account_deployment_data,
+                proof_facts,
             })),
         }
     }

crates/apollo_rpc/src/v0_8/transaction_test.rs

@@ -14,6 +14,7 @@ use starknet_api::transaction::fields::{
     ContractAddressSalt,
     Fee,
     PaymasterData,
+    ProofFacts,
     Tip,
     TransactionSignature,
 };
@@ -120,6 +121,7 @@ auto_impl_get_test_instance! {
         pub account_deployment_data: AccountDeploymentData,
         pub nonce_data_availability_mode: DataAvailabilityMode,
         pub fee_data_availability_mode: DataAvailabilityMode,
+        pub proof_facts: ProofFacts,
     }
     pub enum TransactionVersion0 {
         Version0 = 0,

crates/apollo_starknet_client/src/reader/objects/transaction.rs

@@ -22,6 +22,7 @@ use starknet_api::transaction::fields::{
     ContractAddressSalt,
     Fee,
     PaymasterData,
+    ProofFacts,
     Tip,
     TransactionSignature,
     ValidResourceBounds,
@@ -629,7 +630,7 @@ impl TryFrom<IntermediateInvokeTransaction> for starknet_api::transaction::Invok
                     msg: "Invoke V3 must contain account_deployment_data field.".to_string(),
                 },
             )?,
-            proof_facts: vec![],
+            proof_facts: ProofFacts::default(),
         })
     }
 }

crates/apollo_storage/src/serialization/serializers.rs

@@ -85,6 +85,7 @@ use starknet_api::transaction::fields::{
     ContractAddressSalt,
     Fee,
     PaymasterData,
+    ProofFacts,
     Resource,
     ResourceBounds,
     Tip,
@@ -155,6 +156,7 @@ const COMPRESSION_THRESHOLD_BYTES: usize = 384;
 
 auto_storage_serde! {
     pub struct AccountDeploymentData(pub Vec<Felt>);
+    pub struct ProofFacts(pub Vec<Felt>);
     pub struct AllResourceBounds {
         pub l1_gas: ResourceBounds,
         pub l2_gas: ResourceBounds,
@@ -1292,7 +1294,7 @@ auto_storage_serde_conditionally_compressed! {
         pub fee_data_availability_mode: DataAvailabilityMode,
         pub paymaster_data: PaymasterData,
         pub account_deployment_data: AccountDeploymentData,
-        pub proof_facts: Vec<Felt>,
+        pub proof_facts: ProofFacts,
     }
 
     pub struct L1HandlerTransaction {

crates/apollo_test_utils/src/lib.rs

@@ -122,6 +122,7 @@ use starknet_api::transaction::fields::{
     ContractAddressSalt,
     Fee,
     PaymasterData,
+    ProofFacts,
     Resource,
     ResourceBounds,
     Tip,
@@ -426,6 +427,7 @@ pub trait GetTestInstance: Sized {
 
 auto_impl_get_test_instance! {
     pub struct AccountDeploymentData(pub Vec<Felt>);
+    pub struct ProofFacts(pub Vec<Felt>);
     pub struct AllResourceBounds {
         pub l1_gas: ResourceBounds,
         pub l2_gas: ResourceBounds,
@@ -725,7 +727,7 @@ auto_impl_get_test_instance! {
         pub fee_data_availability_mode: DataAvailabilityMode,
         pub paymaster_data: PaymasterData,
         pub account_deployment_data: AccountDeploymentData,
-        pub proof_facts: Vec<Felt>,
+        pub proof_facts: ProofFacts,
     }
     pub enum L1DataAvailabilityMode {
         Calldata = 0,

crates/native_blockifier/src/py_invoke_function.rs

@@ -10,6 +10,7 @@ use starknet_api::transaction::fields::{
     Calldata,
     Fee,
     PaymasterData,
+    ProofFacts,
     Tip,
     TransactionSignature,
 };
@@ -103,7 +104,7 @@ impl TryFrom<PyInvokeTransactionV3> for InvokeTransactionV3 {
                 tx.account_deployment_data,
             )),
             // TODO(AvivG): Get from PyInvokeTransactionV3 once supported.
-            proof_facts: vec![],
+            proof_facts: ProofFacts::default(),
         })
     }
 }

crates/starknet_api/src/rpc_transaction.rs

@@ -20,6 +20,7 @@ use crate::transaction::fields::{
     Calldata,
     ContractAddressSalt,
     PaymasterData,
+    ProofFacts,
     Tip,
     TransactionSignature,
     ValidResourceBounds,
@@ -630,7 +631,7 @@ impl From<RpcInvokeTransactionV3> for InvokeTransactionV3 {
             paymaster_data: tx.paymaster_data,
             account_deployment_data: tx.account_deployment_data,
             // TODO(AvivG): Get from RpcInvokeTransactionV3 once supported.
-            proof_facts: vec![],
+            proof_facts: ProofFacts::default(),
         }
     }
 }