apollo_protobuf: add proof facts to invoke v3 (#10658)

Author: avivg-starkware

crates/apollo_protobuf/src/converters/transaction.rs

@@ -637,6 +637,10 @@ impl TryFrom<protobuf::InvokeV3> for InvokeTransactionV3 {
                 .collect::<Result<Vec<_>, _>>()?,
         );
 
+        let proof_facts = ProofFacts(
+            value.proof_facts.into_iter().map(Felt::try_from).collect::<Result<Vec<_>, _>>()?,
+        );
+
         Ok(Self {
             resource_bounds,
             tip,
@@ -648,9 +652,7 @@ impl TryFrom<protobuf::InvokeV3> for InvokeTransactionV3 {
             fee_data_availability_mode,
             paymaster_data,
             account_deployment_data,
-            // TODO(AvivG): Get proof_facts from P2P protocol, until then, lost during protobuf
-            // serialization/deserialization.
-            proof_facts: ProofFacts::default(),
+            proof_facts,
         })
     }
 }
@@ -684,6 +686,12 @@ impl From<InvokeTransactionV3> for protobuf::InvokeV3 {
                 .iter()
                 .map(|account_deployment_data| (*account_deployment_data).into())
                 .collect(),
+            proof_facts: value
+                .proof_facts
+                .0
+                .iter()
+                .map(|proof_fact| (*proof_fact).into())
+                .collect(),
         }
     }
 }

crates/apollo_protobuf/src/converters/transaction_test.rs

@@ -3,12 +3,7 @@ use lazy_static::lazy_static;
 use rand::random;
 use starknet_api::block::GasPrice;
 use starknet_api::execution_resources::{Builtin, ExecutionResources, GasAmount, GasVector};
-use starknet_api::transaction::fields::{
-    AllResourceBounds,
-    ProofFacts,
-    ResourceBounds,
-    ValidResourceBounds,
-};
+use starknet_api::transaction::fields::{AllResourceBounds, ResourceBounds, ValidResourceBounds};
 use starknet_api::transaction::{
     DeclareTransaction,
     DeclareTransactionOutput,
@@ -126,8 +121,6 @@ fn convert_invoke_transaction_v3_to_vec_u8_and_back() {
     let mut transaction =
         starknet_api::transaction::InvokeTransactionV3::get_test_instance(&mut rng);
     transaction.resource_bounds = *RESOURCE_BOUNDS_MAPPING;
-    // TODO(AvivG): Remove this once proof_facts is added to P2P protocol.
-    transaction.proof_facts = ProofFacts::default();
     let transaction = StarknetApiTransaction::Invoke(InvokeTransaction::V3(transaction));
 
     let transaction_output = create_transaction_output!(InvokeTransactionOutput, Invoke);

crates/apollo_protobuf/src/proto/p2p/proto/transaction.proto

@@ -60,6 +60,7 @@ message InvokeV3 {
     VolitionDomain nonce_data_availability_mode = 8;
     VolitionDomain fee_data_availability_mode = 9;
     Felt252 nonce = 10;
+    repeated Felt252 proof_facts = 11;
 }
 
 // see https://external.integration.starknet.io/feeder_gateway/get_transaction?transactionHash=0x29fd7881f14380842414cdfdd8d6c0b1f2174f8916edcfeb1ede1eb26ac3ef0

crates/apollo_protobuf/src/protobuf/protoc_output.rs

@@ -303,6 +303,8 @@ pub struct InvokeV3 {
     pub fee_data_availability_mode: i32,
     #[prost(message, optional, tag = "10")]
     pub nonce: ::core::option::Option<Felt252>,
+    #[prost(message, repeated, tag = "11")]
+    pub proof_facts: ::prost::alloc::vec::Vec<Felt252>,
 }
 /// see <https://external.integration.starknet.io/feeder_gateway/get_transaction?transactionHash=0x29fd7881f14380842414cdfdd8d6c0b1f2174f8916edcfeb1ede1eb26ac3ef0>
 #[allow(clippy::derive_partial_eq_without_eq)]

crates/apollo_rpc/src/v0_8/transaction.rs

@@ -467,6 +467,7 @@ impl From<InvokeTransactionV3> for client_transaction::InvokeTransaction {
             paymaster_data: tx.paymaster_data,
             account_deployment_data: tx.account_deployment_data,
             r#type: client_transaction::InvokeType::Invoke,
+            proof_facts: tx.proof_facts,
         })
     }
 }

crates/apollo_starknet_client/resources/writer/invoke_v3.json

@@ -33,5 +33,6 @@
     "nonce_data_availability_mode": 0,
     "fee_data_availability_mode": 0,
     "paymaster_data": [],
-    "account_deployment_data": []
+    "account_deployment_data": [],
+    "proof_facts": []
 }

crates/apollo_starknet_client/src/writer/objects/transaction.rs

@@ -34,6 +34,7 @@ use starknet_api::transaction::fields::{
     DeprecatedResourceBoundsMapping,
     Fee,
     PaymasterData,
+    ProofFacts,
     Tip,
     TransactionSignature,
 };
@@ -179,6 +180,7 @@ pub struct InvokeV3Transaction {
     pub fee_data_availability_mode: ReservedDataAvailabilityMode,
     pub paymaster_data: PaymasterData,
     pub account_deployment_data: AccountDeploymentData,
+    pub proof_facts: ProofFacts,
     pub version: TransactionVersion,
     pub r#type: InvokeType,
 }