Merge pull request #10450 from starkware-libs/dori/merge-main-v0.14.1-committer-into-main-1764243467

Merge main-v0.14.1-committer into main

Author: dorimedini-starkware

.cargo/config.toml

@@ -2,11 +2,3 @@
 LLVM_SYS_191_PREFIX = "/usr/lib/llvm-19/"
 MLIR_SYS_190_PREFIX = "/usr/lib/llvm-19/"
 TABLEGEN_190_PREFIX = "/usr/lib/llvm-19/"
-
-# Use `lld` for linking instead of `ld`, since we run out of memory while linking with `ld` on
-# 16-cores linux machines, see:
-# https://nnethercote.github.io/perf-book/build-configuration.html#linking.
-# TODO(Gilad): remove this once `rust` stabilizes `lld` as the default linker, currently only on nightly:
-# https://github.com/rust-lang/rust/issues/39915#issuecomment-618726211
-[target.'cfg(all(target_os = "linux"))']
-rustflags = ["-Clink-arg=-fuse-ld=lld"]

.dockerignore

@@ -3,4 +3,3 @@
 /logs
 **/target/
 .git
-!crates/papyrus_load_test/resources

.github/CODEOWNERS

@@ -0,0 +1,6 @@
+# GitHub CODEOWNERS file
+# This file defines who must review and approve changes to specific files or directories
+# For more information, see: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
+
+# Require approval from the sequencer-cargo-owners team for workspace dependency changes
+Cargo.toml @starkware-libs/sequencer-cargo-owners

.github/ISSUE_TEMPLATE/01_BUG_REPORT.md

@@ -1,14 +1,14 @@
 ---
 name: Bug Report
-about: Create a report to help Papyrus to improve
+about: Create a report to help Apollo to improve
 title: "bug: "
 labels: "bug"
 assignees: ""
 ---
 
 # Bug Report
 
-**Papyrus version:**
+**Apollo version:**
 
 <!-- Please specify commit or tag version. -->
 

.github/ISSUE_TEMPLATE/config.yml

@@ -12,14 +12,6 @@ inputs:
 runs:
   using: "composite"
   steps:
-    - name: Install ldd
-      shell: bash
-      run: |
-        sudo apt-get update
-        sudo apt-get remove -y man-db
-        sudo apt-mark hold man-db
-        sudo apt-get install -y --no-install-recommends build-essential binutils lld
-
     - name: Install rust.
       uses: ./.github/actions/install_rust
       with:

.github/actions/bootstrap/action.yml

@@ -21,7 +21,6 @@ runs:
         # Install additional non-default toolchains (for rustfmt for example), NOP if input omitted.
         channel: ${{ inputs.extra_rust_toolchains }}
       env:
-        RUSTFLAGS: "-C link-arg=-fuse-ld=lld"
         GITHUB_TOKEN: ${{ inputs.github_token }}
 
     # This installation is _not_ cached, but takes a couple seconds: it's downloading prepackaged

.github/actions/install_rust/action.yml

@@ -37,7 +37,9 @@ on:
       - "scripts/sequencer-ci.Dockerfile"
 
 env:
-  RUSTFLAGS: "-D warnings -C link-arg=-fuse-ld=lld"
+  RUSTFLAGS: "-D warnings"
+  TRANSFERS_BENCHMARK_CAIRO_NATIVE_TIME_LIMIT_NS: "200000000"
+  TRANSFERS_BENCHMARK_VM_TIME_LIMIT_NS: "1000000000"
 
 # On PR events, cancel existing CI runs on this same PR for this workflow.
 # Also, create different concurrency groups for different pushed commits, on push events.
@@ -92,3 +94,43 @@ jobs:
       # tracing is not activated by any workspace crate; test the build.
       - run: cargo build -p blockifier --features tracing
       - run: cargo test -p blockifier --features tracing
+
+  # TODO(Dori): Uncomment once the merge to main is complete (bench_tools does not exist on commit
+  #   github.base_ref).
+  # benchmarking:
+  #   runs-on: namespace-profile-medium-ubuntu-24-04-amd64
+  #   if: ${{ github.event_name == 'pull_request' }}
+  #   steps:
+  #     # Checkout the base branch to benchmark the old code.
+  #     - uses: actions/checkout@v4
+  #       with:
+  #         ref: ${{ github.base_ref }}
+
+  #     - uses: ./.github/actions/bootstrap
+  #       with:
+  #         github_token: ${{ secrets.GITHUB_TOKEN }}
+
+  #     # Restore cargo artifacts build cache.
+  #     - name: Restore Cargo build cache
+  #       uses: Swatinem/rust-cache@v2
+  #       with:
+  #         shared-key: blockifier-bench
+  #         cache-on-failure: true
+  #         cache-workspace-crates: true
+
+  #     # Benchmark the base branch code.
+  #     - run: cargo run -p bench_tools -- run --package blockifier --out /tmp/base_results
+
+  #     # Checkout the current branch to benchmark the new code.
+  #     - uses: actions/checkout@v4
+  #       with:
+  #         clean: false
+
+  #     # Benchmark the current branch and compare to the previous run.
+  #     - run: |
+  #         cargo run -p bench_tools -- run-and-compare \
+  #           --package blockifier \
+  #           --out /tmp/new_results \
+  #           --regression-limit 8.0 \
+  #           --set-absolute-time-ns-limit transfers_benchmark_cairo_native ${TRANSFERS_BENCHMARK_CAIRO_NATIVE_TIME_LIMIT_NS} \
+  #           --set-absolute-time-ns-limit transfers_benchmark_vm ${TRANSFERS_BENCHMARK_VM_TIME_LIMIT_NS}

.github/workflows/blockifier_ci.yml

@@ -14,7 +14,7 @@ on:
       - "scripts/dependencies.sh"
 
 env:
-  RUSTFLAGS: "-D warnings -C link-arg=-fuse-ld=lld"
+  RUSTFLAGS: "-D warnings"
 
 # On PR events, cancel existing CI runs on this same PR for this workflow.
 # Also, create different concurrency groups for different pushed commits, on push events.

.github/workflows/blockifier_compiled_cairo.yml

@@ -19,7 +19,7 @@ on:
       - "scripts/sequencer-ci.Dockerfile"
 
 env:
-  RUSTFLAGS: "-D warnings -C link-arg=-fuse-ld=lld"
+  RUSTFLAGS: "-D warnings"
 
 # On PR events, cancel existing CI runs on this same PR for this workflow.
 # Also, create different concurrency groups for different pushed commits, on push events.