Skip to content

Commit ca34361

Browse files
apollo rpc: add proof_facts to invoke v3
1 parent 93f986b commit ca34361

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

crates/apollo_rpc/src/v0_8/api/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -619,6 +619,7 @@ impl From<InvokeTransaction> for starknet_api::transaction::InvokeTransaction {
619619
account_deployment_data,
620620
nonce_data_availability_mode,
621621
fee_data_availability_mode,
622+
proof_facts,
622623
}) => Self::V3(starknet_api::transaction::InvokeTransactionV3 {
623624
resource_bounds: resource_bounds.into(),
624625
tip,
@@ -630,8 +631,7 @@ impl From<InvokeTransaction> for starknet_api::transaction::InvokeTransaction {
630631
fee_data_availability_mode,
631632
paymaster_data,
632633
account_deployment_data,
633-
// TODO(AvivG): Get proof facts from rpc_v8 once supported.
634-
proof_facts: vec![],
634+
proof_facts,
635635
}),
636636
}
637637
}

crates/apollo_rpc/src/v0_8/transaction.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -447,7 +447,7 @@ pub struct InvokeTransactionV3 {
447447
pub account_deployment_data: AccountDeploymentData,
448448
pub nonce_data_availability_mode: DataAvailabilityMode,
449449
pub fee_data_availability_mode: DataAvailabilityMode,
450-
// TODO(AvivG): Add proof facts to rpc_v8.
450+
pub proof_facts: Vec<Felt>,
451451
}
452452

453453
impl From<InvokeTransactionV3> for client_transaction::InvokeTransaction {
@@ -537,7 +537,7 @@ impl TryFrom<starknet_api::transaction::InvokeTransaction> for InvokeTransaction
537537
fee_data_availability_mode,
538538
paymaster_data,
539539
account_deployment_data,
540-
proof_facts: _,
540+
proof_facts,
541541
},
542542
) => Ok(Self::Version3(InvokeTransactionV3 {
543543
sender_address,
@@ -551,6 +551,7 @@ impl TryFrom<starknet_api::transaction::InvokeTransaction> for InvokeTransaction
551551
fee_data_availability_mode,
552552
paymaster_data,
553553
account_deployment_data,
554+
proof_facts,
554555
})),
555556
}
556557
}

crates/apollo_rpc/src/v0_8/transaction_test.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ use starknet_api::transaction::fields::{
1919
};
2020
use starknet_api::transaction::{L1HandlerTransaction, Transaction};
2121
use starknet_api::{calldata, contract_address, felt, nonce};
22+
use starknet_types_core::felt::Felt;
2223

2324
use super::super::transaction::{L1HandlerMsgHash, L1L2MsgHash};
2425
use super::{
@@ -120,6 +121,7 @@ auto_impl_get_test_instance! {
120121
pub account_deployment_data: AccountDeploymentData,
121122
pub nonce_data_availability_mode: DataAvailabilityMode,
122123
pub fee_data_availability_mode: DataAvailabilityMode,
124+
pub proof_facts: Vec<Felt>,
123125
}
124126
pub enum TransactionVersion0 {
125127
Version0 = 0,

0 commit comments

Comments
 (0)