Skip to content

Commit dc8e4a6

Browse files
starknet_api: add proof_facts to invoke trait (#10714)
1 parent 5d055b5 commit dc8e4a6

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

crates/starknet_api/src/rpc_transaction.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -607,6 +607,11 @@ impl InvokeTransactionV3Trait for RpcInvokeTransactionV3 {
607607
fn calldata(&self) -> &Calldata {
608608
&self.calldata
609609
}
610+
// TODO(AvivG): Remove #[allow(unused)] when proof_facts is used for hash calculation.
611+
#[allow(unused)]
612+
fn proof_facts(&self) -> &ProofFacts {
613+
&self.proof_facts
614+
}
610615
}
611616

612617
impl TransactionHasher for RpcInvokeTransactionV3 {

crates/starknet_api/src/transaction_hash.rs

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ use crate::transaction::fields::{
1111
Calldata,
1212
ContractAddressSalt,
1313
PaymasterData,
14+
ProofFacts,
1415
ResourceBounds,
1516
Tip,
1617
ValidResourceBounds,
@@ -363,6 +364,9 @@ pub(crate) trait InvokeTransactionV3Trait {
363364
fn calldata(&self) -> &Calldata;
364365
fn sender_address(&self) -> &ContractAddress;
365366
fn nonce(&self) -> &Nonce;
367+
// TODO(AvivG): Remove #[allow(unused)] when proof_facts is used for hash calculation.
368+
#[allow(unused)]
369+
fn proof_facts(&self) -> &ProofFacts;
366370
}
367371

368372
pub(crate) fn get_invoke_transaction_v3_hash<T: InvokeTransactionV3Trait>(
@@ -383,7 +387,7 @@ pub(crate) fn get_invoke_transaction_v3_hash<T: InvokeTransactionV3Trait>(
383387
.get_poseidon_hash();
384388
let calldata_hash =
385389
HashChain::new().chain_iter(transaction.calldata().0.iter()).get_poseidon_hash();
386-
390+
// TODO(AvivG): Add proof_facts to hash calculation.
387391
Ok(TransactionHash(
388392
HashChain::new()
389393
.chain(&INVOKE)
@@ -428,6 +432,11 @@ impl InvokeTransactionV3Trait for InvokeTransactionV3 {
428432
fn calldata(&self) -> &Calldata {
429433
&self.calldata
430434
}
435+
// TODO(AvivG): Remove #[allow(unused)] when proof_facts is used for hash calculation.
436+
#[allow(unused)]
437+
fn proof_facts(&self) -> &ProofFacts {
438+
&self.proof_facts
439+
}
431440
}
432441

433442
#[derive(PartialEq, PartialOrd)]

0 commit comments

Comments
 (0)