starknet_api: add proof_facts to rpc invoke v3 (#10633)

Author: avivg-starkware

crates/apollo_consensus_orchestrator/src/cende/central_objects_test.rs

@@ -111,6 +111,7 @@ use starknet_api::transaction::fields::{
     ContractAddressSalt,
     Fee,
     PaymasterData,
+    ProofFacts,
     ResourceBounds,
     Tip,
     TransactionSignature,
@@ -265,6 +266,7 @@ fn invoke_transaction() -> RpcInvokeTransaction {
         fee_data_availability_mode: DataAvailabilityMode::L1,
         paymaster_data: PaymasterData(vec![]),
         account_deployment_data: AccountDeploymentData(vec![]),
+        proof_facts: ProofFacts::default(),
     })
 }
 
@@ -1059,6 +1061,7 @@ fn test_invoke_tx_size_of() {
     // + internal_invoke_tx.sender_address.dynamic_size()
     // + internal_invoke_tx.signature.dynamic_size()
     // + internal_invoke_tx.tip.dynamic_size();
+    // + internal_invoke_tx.proof_facts.dynamic_size();
 
-    assert_eq!(invoke_tx.size_bytes(), 448);
+    assert_eq!(invoke_tx.size_bytes(), 480);
 }

crates/apollo_http_server/src/deprecated_gateway_transaction.rs

@@ -21,6 +21,7 @@ use starknet_api::transaction::fields::{
     Calldata,
     ContractAddressSalt,
     PaymasterData,
+    ProofFacts,
     ResourceBounds,
     Tip,
     TransactionSignature,
@@ -124,6 +125,7 @@ impl From<DeprecatedGatewayInvokeTransactionV3> for RpcInvokeTransactionV3 {
             account_deployment_data: deprecated_invoke_tx.account_deployment_data,
             nonce_data_availability_mode: deprecated_invoke_tx.nonce_data_availability_mode,
             fee_data_availability_mode: deprecated_invoke_tx.fee_data_availability_mode,
+            proof_facts: ProofFacts::default(),
         }
     }
 }

crates/apollo_infra/src/serde_utils_test.rs

@@ -11,6 +11,7 @@ use starknet_api::rpc_transaction::{
     RpcInvokeTransactionV3,
     RpcTransaction,
 };
+use starknet_api::transaction::fields::ProofFacts;
 use starknet_types_core::felt::Felt;
 
 use crate::serde_utils::SerdeWrapper;
@@ -64,6 +65,7 @@ fn serde_rpc_invoke_tx() {
         account_deployment_data: Default::default(),
         nonce_data_availability_mode: DataAvailabilityMode::L1,
         fee_data_availability_mode: DataAvailabilityMode::L1,
+        proof_facts: ProofFacts::default(),
     };
     let rpc_invoke_tx = RpcInvokeTransaction::V3(invoke_tx);
 

crates/apollo_test_utils/src/lib.rs

@@ -873,6 +873,7 @@ auto_impl_get_test_instance! {
         pub fee_data_availability_mode: DataAvailabilityMode,
         pub paymaster_data: PaymasterData,
         pub account_deployment_data: AccountDeploymentData,
+        pub proof_facts: ProofFacts,
     }
     pub struct SequencerContractAddress(pub ContractAddress);
     pub struct Signature {

crates/starknet_api/src/rpc_transaction.rs

@@ -574,7 +574,9 @@ pub struct RpcInvokeTransactionV3 {
     pub account_deployment_data: AccountDeploymentData,
     pub nonce_data_availability_mode: DataAvailabilityMode,
     pub fee_data_availability_mode: DataAvailabilityMode,
-    // TODO(AvivG): Add proof facts.
+    #[serde(default)]
+    pub proof_facts: ProofFacts,
+    // TODO(AvivG): Add proof field.
 }
 
 impl InvokeTransactionV3Trait for RpcInvokeTransactionV3 {
@@ -630,8 +632,7 @@ impl From<RpcInvokeTransactionV3> for InvokeTransactionV3 {
             fee_data_availability_mode: tx.fee_data_availability_mode,
             paymaster_data: tx.paymaster_data,
             account_deployment_data: tx.account_deployment_data,
-            // TODO(AvivG): Get from RpcInvokeTransactionV3 once supported.
-            proof_facts: ProofFacts::default(),
+            proof_facts: tx.proof_facts,
         }
     }
 }
@@ -658,6 +659,7 @@ impl TryFrom<InvokeTransactionV3> for RpcInvokeTransactionV3 {
             sender_address: value.sender_address,
             calldata: value.calldata,
             account_deployment_data: value.account_deployment_data,
+            proof_facts: value.proof_facts,
         })
     }
 }

crates/starknet_api/src/rpc_transaction_test.rs

@@ -137,9 +137,10 @@ fn test_invoke_tx_size_of() {
         // + tx_v3.fee_data_availability_mode.dynamic_size()
         // + tx_v3.paymaster_data.dynamic_size()
         // + tx_v3.account_deployment_data.dynamic_size();
+        // + tx_v3.proof_facts.dynamic_size();
 
         // Check the size of the V3 invoke transaction.
-        assert_eq!(tx_v3.size_bytes(), 448);
+        assert_eq!(tx_v3.size_bytes(), 480);
     } else {
         panic!("Expected RpcTransaction::Invoke");
     }

crates/starknet_api/src/test_utils/invoke.rs

@@ -158,6 +158,7 @@ pub fn rpc_invoke_tx(invoke_args: InvokeTxArgs) -> RpcTransaction {
         fee_data_availability_mode: invoke_args.fee_data_availability_mode,
         paymaster_data: invoke_args.paymaster_data,
         account_deployment_data: invoke_args.account_deployment_data,
+        proof_facts: invoke_args.proof_facts,
     }))
 }