starknet_api: implement TryFrom from StarknetVersion into Felt #10623
+11
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Artifacts upload workflows: |
dorimedini-starkware
approved these changes
Dec 8, 2025
Collaborator
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)
Yoni-Starkware
force-pushed
the
yoni/apollo_starknet_os_program/block-hash
branch
from
a98bd5d to
89fb75c
Compare
Yoni-Starkware
force-pushed
the
yoni/starknet_api/try-from-sn-version-to-felt
branch
from
8bdd610 to
0ce89fb
Compare
Yoni-Starkware
force-pushed
the
yoni/apollo_starknet_os_program/block-hash
branch
from
89fb75c to
3f30b74
Compare
Yoni-Starkware
force-pushed
the
yoni/starknet_api/try-from-sn-version-to-felt
branch
from
0ce89fb to
32b0c01
Compare
Yoni-Starkware
changed the base branch from
yoni/apollo_starknet_os_program/block-hash
to
main
Yoni-Starkware
commented
Dec 9, 2025
Collaborator
Author
Yoni-Starkware
left a comment
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.