apollo_protobuf: add fee_proposal_fri to sync proto SignedBlockHeader#13957
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR SummaryMedium Risk Overview Updates the Rust converters to roundtrip this new optional field by mapping it to/from Reviewed by Cursor Bugbot for commit f425831. Bugbot is set up for automated code reviews on this repo. Configure here. |
3e86fde to
e9914f7
Compare
ShahakShama
left a comment
There was a problem hiding this comment.
@ShahakShama reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on sirandreww-starkware).
crates/apollo_protobuf/src/proto/p2p/proto/sync/header.proto line 34 at r1 (raw file):
// for now, we assume a small consensus, so this fits in 1M. Else, these will be repeated and extracted from this message. repeated ConsensusSignature signatures = 21; // SNIP-35: proposer's oracle-derived recommended fee. Absent for pre-V0_14_3 blocks.
Add a warning here that this is currently not part of the block hash and the value is trusted
e9914f7 to
3ec6c37
Compare
9142e23 to
df1857a
Compare
sirandreww-starkware
left a comment
There was a problem hiding this comment.
@sirandreww-starkware made 1 comment.
Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on ShahakShama).
crates/apollo_protobuf/src/proto/p2p/proto/sync/header.proto line 34 at r1 (raw file):
Previously, ShahakShama wrote…
Add a warning here that this is currently not part of the block hash and the value is trusted
Done.
ShahakShama
left a comment
There was a problem hiding this comment.
@ShahakShama reviewed 3 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).
3ec6c37 to
f425831
Compare
Merge activity
|

No description provided.