Skip to content

apollo_protobuf: add fee_proposal_fri to sync proto SignedBlockHeader#13957

Merged
sirandreww-starkware merged 1 commit into
mainfrom
05-04-apollo_protobuf_add_fee_proposal_fri_to_sync_proto_signedblockheader
May 6, 2026
Merged

apollo_protobuf: add fee_proposal_fri to sync proto SignedBlockHeader#13957
sirandreww-starkware merged 1 commit into
mainfrom
05-04-apollo_protobuf_add_fee_proposal_fri_to_sync_proto_signedblockheader

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

This was referenced May 5, 2026
@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor Author

sirandreww-starkware commented May 5, 2026

@sirandreww-starkware sirandreww-starkware self-assigned this May 5, 2026
@sirandreww-starkware sirandreww-starkware requested review from ShahakShama and matanl-starkware and removed request for matanl-starkware May 5, 2026 06:55
@sirandreww-starkware sirandreww-starkware marked this pull request as ready for review May 5, 2026 06:56
@cursor
Copy link
Copy Markdown

cursor Bot commented May 5, 2026

PR Summary

Medium Risk
Changes the P2P sync wire format by adding a new optional field to SignedBlockHeader and updating conversions, which can impact cross-version compatibility and header roundtrips.

Overview
Adds fee_proposal_fri (SNIP-35 recommended fee) to the sync SignedBlockHeader protobuf message and regenerates the prost output.

Updates the Rust converters to roundtrip this new optional field by mapping it to/from starknet_api::block::GasPrice, and removes the prior tests’ #[should_panic] expectations now that header serialization/deserialization preserves the field.

Reviewed by Cursor Bugbot for commit f425831. Bugbot is set up for automated code reviews on this repo. Configure here.

@sirandreww-starkware sirandreww-starkware force-pushed the 05-04-apollo_protobuf_add_fee_proposal_fri_to_sync_proto_signedblockheader branch from 3e86fde to e9914f7 Compare May 6, 2026 06:29
Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahakShama reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on sirandreww-starkware).


crates/apollo_protobuf/src/proto/p2p/proto/sync/header.proto line 34 at r1 (raw file):

    // for now, we assume a small consensus, so this fits in 1M. Else, these will be repeated and extracted from this message.
    repeated ConsensusSignature signatures = 21;
    // SNIP-35: proposer's oracle-derived recommended fee. Absent for pre-V0_14_3 blocks.

Add a warning here that this is currently not part of the block hash and the value is trusted

@sirandreww-starkware sirandreww-starkware changed the base branch from 04-19-starknet_api_add_fee_proposal_to_partialblockhashcomponents to graphite-base/13957 May 6, 2026 08:25
@sirandreww-starkware sirandreww-starkware force-pushed the 05-04-apollo_protobuf_add_fee_proposal_fri_to_sync_proto_signedblockheader branch from e9914f7 to 3ec6c37 Compare May 6, 2026 09:06
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/13957 to 04-19-starknet_api_add_fee_proposal_to_partialblockhashcomponents May 6, 2026 09:06
Copy link
Copy Markdown
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware made 1 comment.
Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on ShahakShama).


crates/apollo_protobuf/src/proto/p2p/proto/sync/header.proto line 34 at r1 (raw file):

Previously, ShahakShama wrote…

Add a warning here that this is currently not part of the block hash and the value is trusted

Done.

Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed 3 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).

@sirandreww-starkware sirandreww-starkware force-pushed the 05-04-apollo_protobuf_add_fee_proposal_fri_to_sync_proto_signedblockheader branch from 3ec6c37 to f425831 Compare May 6, 2026 14:57
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 6, 2026

Merge activity

  • May 6, 2:58 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@sirandreww-starkware sirandreww-starkware added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit 511b6da May 6, 2026
23 of 27 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants