Skip to content

Commit 526bef7

Browse files
authored
Fix: Remove SEP-45 client domain attribution and fix server signing (#981)
### What This removes the SEP-45 client attribution requirement since embedded wallets currently do not have a concept of a client domain. It also fixes a bug where the server auth entry is not present in the challenge auth entries. ### Why Blocking SEP-45 client-side implementation. ### Known limitations N/A ### Checklist - [x] Title follows `SDP-1234: Add new feature` or `Chore: Refactor package xyz` format. The Jira ticket code was included if available. - [x] PR has a focused scope and doesn't mix features with refactoring - [x] Tests are included (if applicable) - [ ] `CHANGELOG.md` is updated (if applicable) - [ ] CONFIG/SECRETS changes are updated in helmcharts and deployments (if applicable) - [ ] Preview deployment works as expected - [ ] Ready for production
1 parent 0c0c56b commit 526bef7

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

internal/services/sep45_service.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -253,8 +253,7 @@ func (s *sep45Service) CreateChallenge(ctx context.Context, req SEP45ChallengeRe
253253
TimeBounds: txnbuild.NewTimeout(300),
254254
},
255255
Operations: []txnbuild.Operation{&txnbuild.InvokeHostFunction{
256-
SourceAccount: s.signingKP.Address(),
257-
HostFunction: hostFunction,
256+
HostFunction: hostFunction,
258257
}},
259258
}
260259

0 commit comments

Comments
 (0)