SDP-1619: Add /embedded-wallets/profile to pass verification info
#973
Conversation
JiahuiWho
temporarily deployed
to
Internal SEP Tests
GitHub Actions
Inactive
JiahuiWho
temporarily deployed
to
Receiver Registration - E2E Integration Tests (Stellar)
GitHub Actions
Inactive
|
stellar-disbursement-platform-backend-preview is available here: |
JiahuiWho
temporarily deployed
to
Internal SEP Tests
GitHub Actions
Inactive
JiahuiWho
temporarily deployed
to
Receiver Registration - E2E Integration Tests (Stellar)
GitHub Actions
Inactive
|
stellar-disbursement-platform-backend-preview is available here: |
| AND p.type = $2 | ||
| AND p.status = ANY($3) | ||
| ORDER BY p.updated_at DESC | ||
| LIMIT 1 |
There was a problem hiding this comment.
Can there be multiple pending assets?
There was a problem hiding this comment.
Yes, there can be, but we only need one, and we don’t care which one the user verified with.
JiahuiWho
temporarily deployed
to
Internal SEP Tests
GitHub Actions
Inactive
JiahuiWho
temporarily deployed
to
Receiver Registration - E2E Integration Tests (Stellar)
GitHub Actions
Inactive
JiahuiWho
changed the title
is_verification_pending and pending_asset to embedded wallet refresh token/embedded-wallets/profile to pass verification info
|
stellar-disbursement-platform-backend-preview is available here: |
JiahuiWho
temporarily deployed
to
Internal SEP Tests
GitHub Actions
Inactive
JiahuiWho
temporarily deployed
to
Receiver Registration - E2E Integration Tests (Stellar)
GitHub Actions
Inactive
|
stellar-disbursement-platform-backend-preview is available here: |
JiahuiWho
temporarily deployed
to
Internal SEP Tests
GitHub Actions
Inactive
JiahuiWho
temporarily deployed
to
Receiver Registration - E2E Integration Tests (Stellar)
GitHub Actions
Inactive
|
stellar-disbursement-platform-backend-preview is available here: |
| embeddedWalletModel := EmbeddedWalletModel{dbConnectionPool: dbConnectionPool} | ||
|
|
||
| DeleteAllEmbeddedWalletsFixtures(t, ctx, dbConnectionPool) | ||
| defer DeleteAllEmbeddedWalletsFixtures(t, ctx, dbConnectionPool) |
There was a problem hiding this comment.
Should we also DeleteAllReceiversFixtures?
| }) | ||
| } | ||
|
|
||
| func (e *EmbeddedWalletService) GetReceiverWalletByContractAddress(ctx context.Context, contractAddress string) (*data.ReceiverWallet, error) { |
There was a problem hiding this comment.
nit: We can make this function private since it's only used by isVerificationPending.
| }) | ||
| } | ||
|
|
||
| func (e *EmbeddedWalletService) IsVerificationPending(ctx context.Context, contractAddress string) (bool, error) { |
There was a problem hiding this comment.
This function needs a test.
What
/embedded-wallets/profileto passis_verification_pendingandpending_assetto FEclientAttributionRequiredcheck during SEP-45 challenge creationWhy
is_verification_pendingandpending_assetare needed for FE to initiate the SEP-24 deposit flowclientAttributionRequiredis temporarily removed due to blocking the FE’s SEP‑45 flow:Sep10ClientAttributionRequired, defaulting to true.client_domainbecause it’s self hosted inside SDP, there’s no separate client domain TOML or signing key to reference.Known limitations
N/A
Checklist
SDP-1234: Add new featureorChore: Refactor package xyzformat. The Jira ticket code was included if available.CHANGELOG.mdis updated (if applicable)