Skip to content

Commit 351682e

Browse files
author
Kevin Formsma
authored
Update cfn-model to handle line numbers in SAM (Fixes #574) (#575)
1 parent 0b92d9c commit 351682e

File tree

3 files changed

+16
-16
lines changed

3 files changed

+16
-16
lines changed

Gemfile.lock

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ PATH
33
specs:
44
cfn-nag (0.0.0)
55
aws-sdk-s3 (~> 1.76)
6-
cfn-model (= 0.6.3)
6+
cfn-model (= 0.6.4)
77
lightly (~> 0.3.2)
88
logging (~> 2.2.2)
99
netaddr (~> 2.0.4)
@@ -14,23 +14,23 @@ GEM
1414
remote: https://rubygems.org/
1515
specs:
1616
ast (2.4.2)
17-
aws-eventstream (1.1.1)
18-
aws-partitions (1.487.0)
19-
aws-sdk-core (3.119.0)
17+
aws-eventstream (1.2.0)
18+
aws-partitions (1.516.0)
19+
aws-sdk-core (3.121.1)
2020
aws-eventstream (~> 1, >= 1.0.2)
2121
aws-partitions (~> 1, >= 1.239.0)
2222
aws-sigv4 (~> 1.1)
2323
jmespath (~> 1.0)
24-
aws-sdk-kms (1.46.0)
25-
aws-sdk-core (~> 3, >= 3.119.0)
24+
aws-sdk-kms (1.49.0)
25+
aws-sdk-core (~> 3, >= 3.120.0)
2626
aws-sigv4 (~> 1.1)
27-
aws-sdk-s3 (1.98.0)
28-
aws-sdk-core (~> 3, >= 3.119.0)
27+
aws-sdk-s3 (1.103.0)
28+
aws-sdk-core (~> 3, >= 3.120.0)
2929
aws-sdk-kms (~> 1)
30-
aws-sigv4 (~> 1.1)
31-
aws-sigv4 (1.2.4)
30+
aws-sigv4 (~> 1.4)
31+
aws-sigv4 (1.4.0)
3232
aws-eventstream (~> 1, >= 1.0.2)
33-
cfn-model (0.6.3)
33+
cfn-model (0.6.4)
3434
kwalify (= 0.7.2)
3535
psych (~> 3)
3636
diff-lcs (1.4.4)
@@ -43,7 +43,7 @@ GEM
4343
little-plugger (~> 1.1)
4444
multi_json (~> 1.10)
4545
multi_json (1.15.0)
46-
netaddr (2.0.4)
46+
netaddr (2.0.5)
4747
optimist (3.0.1)
4848
parallel (1.21.0)
4949
parser (3.0.2.0)

cfn-nag.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Gem::Specification.new do |s|
2525
# versus what we used to run tests in cfn-nag before publishing cfn-nag
2626
# they are coupled and we are doing a good bit of experimenting in cfn-model
2727
# i might consider collapsing them again....
28-
s.add_runtime_dependency('cfn-model', '0.6.3')
28+
s.add_runtime_dependency('cfn-model', '0.6.4')
2929
s.add_runtime_dependency('logging', '~> 2.2.2')
3030
s.add_runtime_dependency('netaddr', '~> 2.0.4')
3131
s.add_runtime_dependency('optimist', '~> 3.0.0')

spec/cfn_nag_integration/cfn_nag_serverless_transform_spec.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,19 +25,19 @@
2525
id: 'W58', type: Violation::WARNING,
2626
message: LambdaFunctionCloudWatchLogsRule.new.rule_text,
2727
logical_resource_ids: %w[SomeFunction2],
28-
line_numbers: [-1]
28+
line_numbers: [34]
2929
),
3030
Violation.new(
3131
id: 'W89', type: Violation::WARNING,
3232
message: LambdaFunctionInsideVPCRule.new.rule_text,
3333
logical_resource_ids: ["SomeFunction", "SomeFunction2"],
34-
line_numbers: [-1,-1]
34+
line_numbers: [20, 34]
3535
),
3636
Violation.new(
3737
id: 'W92', type: Violation::WARNING,
3838
message: LambdaFunctionReservedConcurrentExecutionsRule.new.rule_text,
3939
logical_resource_ids: ["SomeFunction","SomeFunction2"],
40-
line_numbers: [-1,-1]
40+
line_numbers: [20, 34]
4141
)
4242
]
4343
}

0 commit comments

Comments
 (0)