Skip to content

Commit 1816def

Browse files
committed
Merge branch 'main' into FW-6790
2 parents 59d57b4 + bede52f commit 1816def

File tree

6 files changed

+26
-10
lines changed

6 files changed

+26
-10
lines changed

CHANGELOG.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,14 @@
1+
## 😋 [4.38.3](https://github.com/stenciljs/core/compare/v4.38.2...v4.38.3) (2025-11-05)
2+
3+
4+
### Bug Fixes
5+
6+
* **runtime:** modern class props detected in collections ([#6431](https://github.com/stenciljs/core/issues/6431)) ([e790c24](https://github.com/stenciljs/core/commit/e790c24f2205677f1f0cd8251110a608c864c5bb))
7+
* **ts:** moduleResolution can now be `bundler`. Configurable module / noEmitOnError ([#6433](https://github.com/stenciljs/core/issues/6433)) ([5018e1e](https://github.com/stenciljs/core/commit/5018e1e3ebf03a4b560bba89a3642698ca3f2d9f))
8+
* **types:** revert autocorrect omission ([#6441](https://github.com/stenciljs/core/issues/6441)) ([4719427](https://github.com/stenciljs/core/commit/47194274cb4d68adb1acb8a37984e9119c78859c))
9+
10+
11+
112
## 🐎 [4.38.2](https://github.com/stenciljs/core/compare/v4.38.1...v4.38.2) (2025-10-17)
213

314

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@stencil/core",
3-
"version": "4.38.2",
3+
"version": "4.38.3",
44
"license": "MIT",
55
"main": "./internal/stencil-core/index.cjs",
66
"module": "./internal/stencil-core/index.js",

src/declarations/stencil-public-runtime.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -395,8 +395,7 @@ export declare function forceUpdate(ref: any): void;
395395
*/
396396
export declare function getRenderingRef(): any;
397397

398-
// TODO: remove `autocorrect` omission when this is properly typed in [in typescript](https://github.com/microsoft/typescript/issues/62083)
399-
export interface HTMLStencilElement extends Omit<HTMLElement, 'autocorrect'> {
398+
export interface HTMLStencilElement extends HTMLElement {
400399
componentOnReady(): Promise<this>;
401400
}
402401

test/ionic-app/tsconfig.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@
2121
"@stencil/core/mock-doc": [
2222
"../../mock-doc"
2323
]
24-
}
24+
},
25+
"skipLibCheck": true
2526
},
2627
"include": ["src"]
2728
}

test/wdio/global.ts

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,21 @@
33
// `stencil-sibling` test suite
44
import 'test-sibling';
55
import { setMode } from '@stencil/core';
6-
// @ts-ignore
6+
7+
// @ts-ignore - this should produce a warning but not cause the build to fail
78
import { setAssetPath } from '@stencil/core/internal/client/index';
89

10+
// this doesn't do anything - just stops rollup removing the import
11+
setAssetPath('/base/path');
12+
13+
export let thing: HTMLElement = globalThis.document ? document.createElement('div') : null;
14+
915
const globalScript = () => {
1016
setMode((elm) => {
17+
// this should be valid as HTMLElement and HTMLStencilElement should be compatible
18+
thing = elm as HTMLAttributeBasicElement;
1119
return (elm as any).colormode || elm.getAttribute('colormode');
1220
});
1321
};
1422

15-
// this doesn't do anything - just stops rollup removing the import
16-
setAssetPath('/base/path');
17-
1823
export default globalScript;

0 commit comments

Comments
 (0)