fix: make tests more accurate

Author: JackYPCOnline

tests_integ/test_build_agent_from_specifications.py

@@ -1,5 +1,3 @@
-"""Test building agent from specification file using semantic creation."""
-
 import sys
 from unittest import mock
 
@@ -8,20 +6,17 @@
 from strands_agents_builder import strands
 
 
-def test_build_agent_from_specification_file(tmp_path):
-    """Test building agent from agent-spec.txt using semantic creation."""
+def test_build_agent_from_specification_file():
+    """Test building agent from specification using semantic creation."""
 
-    # Create agent specification file
+    # Agent specification content
     spec_content = """Agent Specification:
 - Role: Math Tutor Agent
 - Purpose: Help students with basic arithmetic and algebra
 - Tools needed: calculator, file_read, current_time
 - Create specialized tools for math tutoring
 """
 
-    spec_file = tmp_path / "agent-spec.txt"
-    spec_file.write_text(spec_content)
-
     # Simulate: cat agent-spec.txt | strands "Build a specialized agent based on these specifications"
     query = f"Build a specialized agent based on these specifications:\n\n{spec_content}"
 

tests_integ/test_custom_load_from_file.py

@@ -28,4 +28,9 @@ def reverse_text(text: str) -> dict:
     strands.main()
 
     out = capsys.readouterr().out
+    assert (
+        "The reverse_text tool worked as expected"
+        or "The reverse_text tool worked"
+        or ("reverse_text tool" and "The tool successfully reversed") in out
+    ), f"Expected 'olleh' in output, but got:\n{out}"
     assert "olleh" in out, f"Expected 'olleh' in output, but got:\n{out}"

tests_integ/test_sementic_create_tool.py renamed to tests_integ/test_semantic_create_tool.py

@@ -1,4 +1,3 @@
-import io
 import sys
 from unittest import mock
 
@@ -7,15 +6,14 @@
 from strands_agents_builder import strands
 
 
-@mock.patch.object(sys, "stdin")
+@mock.patch("strands_tools.utils.user_input.get_user_input", return_value="y")
 @mock.patch.dict("os.environ", {"STRANDS_TOOL_CONSOLE_MODE": "enabled"})
-def test_interactive_model_create_tool_then_validate(mock_stdin, capsys, tmp_file_structure):
+def test_interactive_model_create_tool_then_validate(mock_get_user_input, capsys, tmp_file_structure):
     """
     Test creating a calculator tool via CLI and validating its functionality.
     """
     with mock.patch.dict("os.environ", {"STRANDS_TOOLS_DIR": str(tmp_file_structure["tools_dir"])}):
         test_query = "create a tool that can only calculate sum of two number called calculator"
-        mock_stdin.return_value = io.StringIO("y\ny\ny\n")
 
         with mock.patch.object(sys, "argv", ["strands", test_query]):
             strands.main()
@@ -33,3 +31,12 @@ def test_interactive_model_create_tool_then_validate(mock_stdin, capsys, tmp_fil
             response = agent(question)
             response_str = str(response).lower()
             assert expected in response_str, f"Expected '{expected}' in response for '{question}', got '{response_str}'"
+
+            # Verify the calculator tool was actually used by checking for toolResults
+            calculator_used = any(
+                content.get("toolUse", {}).get("name") == "calculator"
+                for message in agent.messages
+                for content in message.get("content", [])
+                if content.get("toolUse")
+            )
+            assert calculator_used, f"Calculator tool should have been used for question: '{question}'"