Can't build on Rocky Linux 8

[mephillips423]

I followed the build instructions, but get an error about undefined reference to `pthread_create' and the build does not complete. Should this work?

cat /etc/redhat-release

Rocky Linux release 8.10 (Green Obsidian)

./autogen.sh
./configure --disable-dec265 --disable-sherlock265
make

...
Making all in tools
make[2]: Entering directory '/home/sparky/install/libde265/tools'
g++ -DHAVE_CONFIG_H -I. -I.. -I../libde265 -I.. -g -O2 -Werror=return-type -Werror=unused-result -Werror=reorder -DDE265_LOG_ERROR -MT gen_enc_table-gen-entropy-table.o -MD -MP -MF .deps/gen_enc_table-gen-entropy-table.Tpo -c -o gen_enc_table-gen-entropy-table.o test -f 'gen-entropy-table.cc' || echo './'gen-entropy-table.cc
mv -f .deps/gen_enc_table-gen-entropy-table.Tpo .deps/gen_enc_table-gen-entropy-table.Po
/bin/sh ../libtool --tag=CXX --mode=link g++ -g -O2 -Werror=return-type -Werror=unused-result -Werror=reorder -DDE265_LOG_ERROR -o gen-enc-table gen_enc_table-gen-entropy-table.o ../libde265/libde265.la -lstdc++ -lm
libtool: link: g++ -g -O2 -Werror=return-type -Werror=unused-result -Werror=reorder -DDE265_LOG_ERROR -o .libs/gen-enc-table gen_enc_table-gen-entropy-table.o ../libde265/.libs/libde265.so -lstdc++ -lm -Wl,-rpath -Wl,/usr/local/lib
../libde265/.libs/libde265.so: undefined reference to `pthread_create'
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:495: gen-enc-table] Error 1
make[2]: Leaving directory '/home/prospero/install/libde265/tools'
make[1]: *** [Makefile:507: all-recursive] Error 1
make[1]: Leaving directory '/home/prospero/install/libde265'
make: *** [Makefile:416: all] Error 2

[farindk]

Please use the cmake build system. The autotools scripts are deprecated.
I have changed the build instructions in the readme (06f4f73).

[mephillips423]

Here is the last part using thte cmake instructions. It gives the same error ../libde265/libde265.so: undefined reference to `pthread_create'

...
/home/prospero/install/libde265/libde265/image.h: In member function ‘const slice_segment_header* de265_image::get_SliceHeaderCtb(int, int) const’:
/home/prospero/install/libde265/libde265/image.h:781:13: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector<slice_segment_header*>::size_type’ {aka ‘long unsigned int’} [-Wsign-compare]
if (idx >= slices.size()) { return NULL; }
~~~~^~~~~~~~~~~~~~~~
/home/prospero/install/libde265/dec265/dec265.cc: At global scope:
/home/prospero/install/libde265/dec265/dec265.cc:243:17: warning: ‘uint8_t* convert_to_8bit(const uint8_t*, int, int, int, int)’ defined but not used [-Wunused-function]
static uint8_t* convert_to_8bit(const uint8_t* data, int width, int height,
^~~~~~~~~~~~~~~
[100%] Linking CXX executable dec265
../libde265/libde265.so: undefined reference to `pthread_create'
collect2: error: ld returned 1 exit status
make[2]: *** [dec265/CMakeFiles/dec265.dir/build.make:98: dec265/dec265] Error 1
make[1]: *** [CMakeFiles/Makefile2:303: dec265/CMakeFiles/dec265.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

[mephillips423]

Sorry, the most likely cause is that I am not targeting the correct version for my OS. I was just trying to compile the master branch after fetching from GIT. I switched to using the fusion repository for Rocky Linux 8 and was able to get the correct versions that allow me to build the graphics magick version (1.3.38) that matches the OS version .

[farindk]

For some reason, your compiler (which compiler are you using btw?) does not automatically link to pthread. Since we now use multithreading primitives only through the C++ std library, this should in fact be handled automatically. I'm not sure why this is not the case for you.

You can probably solve it by simply adding "-lpthread" to the two linker arguments below:

if(HAVE_LIBCPP)
  set(LIBS_PRIVATE "-lc++")
else()
  set(LIBS_PRIVATE "-lstdc++")
endif()

Still, I would be interesting which compiler you are using and why it doesn't pull in the dependency automatically.

[mephillips423]

How can I show you the compiler info you need? The output does not seem to show me that info when I use the cmake process and then make.

[farindk]

When running cmake, the two very first lines you get should be something like:

-- The C compiler identification is GNU 13.3.0
-- The CXX compiler identification is Clang 18.1.3

[mephillips423]

-- The C compiler identification is GNU 8.5.0
-- The CXX compiler identification is GNU 8.5.0

[farindk]

That is rather old. I tried with gcc 9.5.0, which is the oldest that is available for my system. It compiled successfully.
I guess you might just make the changes above on your side. Looks like a compiler issue to me.