Remove blocks parameter & test new call signature

Author: bfollington

xcode/Subconscious/Shared/Components/Common/SubtextView.swift

@@ -35,7 +35,7 @@ struct SubtextView: View {
     }
 
     var blocks: [RenderableBlock] {
-        Self.renderer.render(subtext, blocks: subtext.blocks)
+        Self.renderer.render(subtext)
             .compactMap { rendered in
                 guard !rendered.block.isEmpty else {
                     return nil

xcode/Subconscious/Shared/Parsers/SubtextAttributedStringRenderer.swift

@@ -167,12 +167,14 @@ struct SubtextAttributedStringRenderer {
         return markup
     }
 
-    func render(_ subtext: Subtext, blocks: [Subtext.Block]) -> [Subtext.RenderedBlock] {
+    // Convenience method to re-use parsed Subtext and return each block rendered independently.
+    // This is a peformance optimization for SubtextView.
+    func render(_ subtext: Subtext) -> [Subtext.RenderedBlock] {
         // Initial contiguous AttributedString creation with all attributes applied
         var markup = AttributedString(subtext.base)
         markup.font = .body
 
-        for block in blocks {
+        for block in subtext.blocks {
             renderAttributesOf(attributedString: &markup, block: block)
             for inline in block.inline {
                 renderAttributesOf(
@@ -186,7 +188,7 @@ struct SubtextAttributedStringRenderer {
         var attributedStringsForBlocks: [Subtext.RenderedBlock] = []
 
         // Extract and append AttributedString for each block
-        for block in blocks {
+        for block in subtext.blocks {
             guard let blockRange = block.span.range.within(attributedString: markup) else {
                 continue
             }

xcode/Subconscious/SubconsciousTests/Tests_SubtextAttributedStringRenderer.swift

@@ -70,6 +70,36 @@ final class Tests_SubtextAttributedStringRenderer: XCTestCase {
         XCTAssertEqual(link.fallback, "Lo and behold")
     }
 
+    func testAlternativeSignatures() {
+        let subtext = Subtext(
+            markup: """
+                     Related: [[Sara Walker]], [[Stuart Kauffman]] [[SFI]], [[Assembly Theory]], [[Emergence comes from alphabets]], [[Alphabet]]
+                     
+                     # Mentioned Papers
+                     
+                     - Intelligence as a planetary scale process by Adam Frank, David Grinspoon & [[Sara Walker]]
+                     - [[The Algorithmic Origins of Life]] by Sara Imari Walker & Paul C. W. Davies
+                     """
+        )
+        
+        let renderer = SubtextAttributedStringRenderer()
+        let a = renderer.render(subtext)
+        let b = renderer.render(subtext.description)
+        
+        var joined = AttributedString()
+        for block in a {
+            joined.append(block.renderedSubstring)
+            if block != a.last {
+                joined.append(AttributedString("\n"))
+            }
+        }
+        
+        XCTAssertEqual(
+            joined.characters.map { String($0) }.joined(separator: ""),
+            b.characters.map { String($0) }.joined(separator: "")
+        )
+    }
+    
     func testPerformance() throws {
         let renderer = SubtextAttributedStringRenderer()
         let attributedString = NSMutableAttributedString(