Skip to content

Commit 90d9ff9

Browse files
authored
Fix: bumping interdependency only for packages instead of all vendor packages (#87)
1 parent 2c3f8a4 commit 90d9ff9

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

src/Command/BumpInterdependencyCommand.php

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
use Symplify\MonorepoBuilder\FileSystem\ComposerJsonProvider;
1212
use Symplify\MonorepoBuilder\Validator\SourcesPresenceValidator;
1313
use Symplify\PackageBuilder\Console\Command\AbstractSymplifyCommand;
14-
use Symplify\SymplifyKernel\Exception\ShouldNotHappenException;
1514

1615
final class BumpInterdependencyCommand extends AbstractSymplifyCommand
1716
{
@@ -46,18 +45,11 @@ protected function execute(InputInterface $input, OutputInterface $output): int
4645
/** @var string $version */
4746
$version = $input->getArgument(self::VERSION_ARGUMENT);
4847

49-
$rootComposerJson = $this->composerJsonProvider->getRootComposerJson();
48+
$packageNames = $this->composerJsonProvider->getPackageNames();
5049

51-
// @todo resolve better for only found packages
52-
// see https://github.com/symplify/symplify/pull/1037/files
53-
$vendorName = $rootComposerJson->getVendorName();
54-
if ($vendorName === null) {
55-
throw new ShouldNotHappenException();
56-
}
57-
58-
$this->dependencyUpdater->updateFileInfosWithVendorAndVersion(
50+
$this->dependencyUpdater->updateFileInfosWithPackagesAndVersion(
5951
$this->composerJsonProvider->getPackagesComposerFileInfos(),
60-
$vendorName,
52+
$packageNames,
6153
$version
6254
);
6355

0 commit comments

Comments
 (0)