NGSIv1 removal pending issues and follow ups

[fgalan]

PR #4603 start the removal, but some items are still pending:

• Unify serviceRoutines/ and serviceRoutinesV2/ (first has badVerds and some other leftover method) - actually it was done in PR REMOVE NGSIv1 dead code #4603
• In 3707_get_or_change_log_config/get_or_change_log_config.test some tests use "error" but no "description" - PR FIX admin log error responses #4687
• In 1913_log_level_change_via_rest/log_level_change_via_rest.test some tests use "error" but no "description" - PR FIX admin log error responses #4687
• Search "false" and "true" literals (with quotes) - PR FIX use booleans for csub and registrations isPattern fields #4696
• isPattern (text-based) are very ugly (classs apiv2types/Entity). Search for isPattern to see if they can be removed, using idPattern instead - PR FIX use booleans for csub and registrations isPattern fields #4696
• CSUB_ENTITY_ISPATTERN -> pattern true|false (if we are going to remove this in the registrations collection, we should do the same here...) - PR FIX use booleans for csub and registrations isPattern fields #4696
• Check updateAttrInNotifyCer() needs useDefaultType or if its value is always fixed to true - PR NGSIv1 cleanup followup #4698 (commit d76e54d)
• usage of typeGiven in Entity - PR NGSIv1 cleanup followup #4698 (commit 813fedf)
• Check toBson() needs useDefaultType or if its value is always fixed to true - PR NGSIv1 cleanup followup #4698 (commit 32d1b45)
• Check if appendToBson() needs useDefaultType or if its value is always fixed to true - PR NGSIv1 cleanup followup #4698 (commit 8dece4b)
• forbidenIdCharsV2 -> remove V2 sufix. Search V2( to check more on this. - PR NGSIv1 cleanup followup #4698 (commits 1800b04, 666593c and 040e462)
• Remove NGSIv1 scopes (along with EntityTypeInfo.h) -PR FIX remove Scope classes (and related stuff) #4702
• The logic to build the response (payload) for postUpdateContext() is not needed. In NGSIv2 with OrionError is enough
• postQueryContext -> doQuery
• postUpdateContext -> doUpdate
• inner and outer StatusCode in some requests (updates?) adaptErrorCodeForSingleEntityOperation
• Excessive usage of StatusCode. Replace by OrionError
• Unify Attribute + ContextAttribute, etc. with the rest of types apparently duplicated
• CE, CER, CRR, CRRV, CRV, CERV, Context, providerApplication, etc.
• Search (case insensitive): NGSIv1 NGSI-v1 v1 ngsi10
• New issue with the deprecation for legacyForwarding (similar to this one Remove geo:point, geo:box and geo:polygon functionality #4589)

Not directly related to NGSIv1 removal, but detected during this work:

• parseEntitiesResponse potential leak at the end. Memory is not release in case of parse error. Create a .test to raise the leak first. Review V2 parsing logic searching for new

  for (rapidjson::Value::ConstValueIterator iter = document.Begin(); iter != document.End(); ++iter)
  {
    Entity* eP = new Entity();

    std::string s = parseEntityObject(ciP, iter, eP, true, true);
    if (s != "OK")
    {
      oeP->fill(SccBadRequest, s);
      alarmMgr.badInput(clientIp, "JSON Parse Error", s);
      ciP->httpStatusCode = SccBadRequest;
      return false;
    }

    evP->vec.push_back(eP);
  }

Edit: some fixes in this line were done in the last commits of PR #4603 (1e72568, d9a3739 ) although a more exhaustive analysis should be done.

• ForwardingInformation not working

  //
  // FIXME P6: once forwarding is implemented for APIv2, include this call
  // jh.addRaw("forwardingInformation", forwardingInformation.toJson());
  //

• Align scripts/style_check_in_makefile.sh with src/lib and test/unittest (alphabetical order would be clearer)

• Guards with empty types. Mark for removal