Handle error 404 when looping on the sites (#57)

See home-assistant/core#42526

Author: tetienne

.codeclimate.yml

@@ -0,0 +1,5 @@
+version: "2"         # required to adjust maintainability checks
+checks:
+  method-complexity:
+    config:
+      threshold: 10

CHANGELOG.md

@@ -1,3 +1,5 @@
+### 0.9.1
+* Handle error 404 when site has not device
 ### 0.9.0
 * Add parent id support
 ### 0.8.0

pymfy/api/somfy_api.py

@@ -1,3 +1,4 @@
+from json import JSONDecodeError
 from typing import Any, Callable, Dict, List, Optional, Tuple, Union
 
 from oauthlib.oauth2 import TokenExpiredError
@@ -62,10 +63,18 @@ def get_devices(
         devices = []  # type: List[Device]
         for s_id in site_ids:
             response = self.get("/site/" + s_id + "/device")
-            response.raise_for_status()
+            try:
+                content = response.json()
+            except JSONDecodeError:
+                response.raise_for_status()
+
+            if response.status_code != 200:
+                # Can happen when the site does not contain any device
+                continue
+
             devices += [
                 Device(**d)
-                for d in response.json()
+                for d in content
                 if category is None or category.value in Device(**d).categories
             ]
         return devices

tests/get_devices_3.json

@@ -0,0 +1,5 @@
+{
+    "uid": "XXXXX",
+    "message": "definition_not_found",
+    "data": null
+  }

tests/get_sites.json

@@ -6,5 +6,9 @@
   {
     "id": "site-2",
     "label": "Conexoon"
+  },
+  {
+    "id": "site-3",
+    "label": "Other"
   }
 ]

tests/test_somfy_api.py

@@ -22,7 +22,7 @@ def test_get_sites(self, api):
                 httpretty.GET, BASE_URL + "/site", body=get_sites.read()
             )
         sites = api.get_sites()
-        assert len(sites) == 2
+        assert len(sites) == 3
         assert sites[0].id == "site-1"
         assert sites[0].label == "TaHoma"
         assert sites[1].id == "site-2"
@@ -43,9 +43,12 @@ def test_devices(self, api):
         sites_path = os.path.join(CURRENT_DIR, "get_sites.json")
         devices_path_1 = os.path.join(CURRENT_DIR, "get_devices_1.json")
         devices_path_2 = os.path.join(CURRENT_DIR, "get_devices_2.json")
+        devices_path_3 = os.path.join(CURRENT_DIR, "get_devices_3.json")
         with open(sites_path, "r") as get_sites, open(
             devices_path_1, "r"
-        ) as get_devices_1, open(devices_path_2, "r") as get_devices_2:
+        ) as get_devices_1, open(devices_path_2, "r") as get_devices_2, open(
+            devices_path_3, "r"
+        ) as get_devices_3:
             httpretty.register_uri(
                 httpretty.GET, BASE_URL + "/site", body=get_sites.read()
             )
@@ -59,6 +62,12 @@ def test_devices(self, api):
                 BASE_URL + "/site/site-2/device",
                 body=get_devices_2.read(),
             )
+            httpretty.register_uri(
+                httpretty.GET,
+                BASE_URL + "/site/site-3/device",
+                body=get_devices_3.read(),
+                status=404,
+            )
 
         assert len(api.get_devices()) == 4
         assert len(api.get_devices("site-1")) == 3