Terraform plugin crash

[sanbrien]

Steps to reproduce

1. Create 2 terraform modules: one for setting up the VPC and subnets and one separate module for setting up VPC FW rules + SecurityGroups.
2. Run terraform plan on both modules.
3. Make a change to the VPC module that triggers a recreate (e.g. VPC name) of the resources. This removes also FW rules and SecurityGroups.
4. Run terraform plan on the security layer.

Expected outcome

After running terraform plan on the security layer, I do expect Terraform to complain that the infra is out of sync with local config.

Actual outcome

The plugin crashes with the following output:

Logs:

Error: Plugin did not respond
│ 
│   with thalassa_security_group.sg_web_lb,
│   on main.tf line 4, in resource "thalassa_security_group" "sg_web_lb":
│    4: resource "thalassa_security_group" "sg_web_lb" {
│ 
│ The plugin encountered an error, and failed to respond to the plugin.(*GRPCProvider).ReadResource call. The plugin logs may contain more
│ details.
╵
╷
│ Error: Request cancelled
│ 
│   with thalassa_security_group.sg_k8s_nodes,
│   on main.tf line 52, in resource "thalassa_security_group" "sg_k8s_nodes":
│   52: resource "thalassa_security_group" "sg_k8s_nodes" {
│ 
│ The plugin.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│ 
│   with thalassa_security_group.sg_k8s_db,
│   on main.tf line 139, in resource "thalassa_security_group" "sg_k8s_db":
│  139: resource "thalassa_security_group" "sg_k8s_db" {
│ 
│ The plugin.(*GRPCProvider).ReadResource request was cancelled.
╵
╷
│ Error: Request cancelled
│ 
│   with thalassa_security_group.sg_monitoring,
│   on main.tf line 223, in resource "thalassa_security_group" "sg_monitoring":
│  223: resource "thalassa_security_group" "sg_monitoring" {
│ 
│ The plugin.(*GRPCProvider).ReadResource request was cancelled.
╵
╷
│ Error: Request cancelled
│ 
│   with thalassa_security_group.sg_monitoring_vm,
│   on main.tf line 256, in resource "thalassa_security_group" "sg_monitoring_vm":
│  256: resource "thalassa_security_group" "sg_monitoring_vm" {
│ 
│ The plugin.(*GRPCProvider).ReadResource request was cancelled.
╵
╷
│ Error: Request cancelled
│ 
│   with thalassa_vpc_firewall_rule.wg[0],
│   on main.tf line 335, in resource "thalassa_vpc_firewall_rule" "wg":
│  335: resource "thalassa_vpc_firewall_rule" "wg" {
│ 
│ The plugin.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Plugin did not respond
│ 
│   with thalassa_vpc_firewall_rule.np[0],
│   on main.tf line 351, in resource "thalassa_vpc_firewall_rule" "np":
│  351: resource "thalassa_vpc_firewall_rule" "np" {
│ 
│ The plugin encountered an error, and failed to respond to the plugin.(*GRPCProvider).ReadResource call. The plugin logs may contain more
│ details.
╵
╷
│ Error: Request cancelled
│ 
│   with thalassa_vpc_firewall_rule.klt[0],
│   on main.tf line 367, in resource "thalassa_vpc_firewall_rule" "klt":
│  367: resource "thalassa_vpc_firewall_rule" "klt" {
│ 
│ The plugin.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│ 
│   with thalassa_vpc_firewall_rule.kubelet_from_cp_to_db[0],
│   on main.tf line 399, in resource "thalassa_vpc_firewall_rule" "kubelet_from_cp_to_db":
│  399: resource "thalassa_vpc_firewall_rule" "kubelet_from_cp_to_db" {
│ 
│ The plugin.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│ 
│   with thalassa_vpc_firewall_rule.db[0],
│   on main.tf line 415, in resource "thalassa_vpc_firewall_rule" "db":
│  415: resource "thalassa_vpc_firewall_rule" "db" {
│ 
│ The plugin.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│ 
│   with thalassa_vpc_firewall_rule.icmp[0],
│   on main.tf line 431, in resource "thalassa_vpc_firewall_rule" "icmp":
│  431: resource "thalassa_vpc_firewall_rule" "icmp" {
│ 
│ The plugin.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│ 
│   with thalassa_vpc_firewall_rule.mon_to_db_nodeexp[0],
│   on main.tf line 446, in resource "thalassa_vpc_firewall_rule" "mon_to_db_nodeexp":
│  446: resource "thalassa_vpc_firewall_rule" "mon_to_db_nodeexp" {
│ 
│ The plugin.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│ 
│   with thalassa_vpc_firewall_rule.mon_to_nodes_nodeexp[0],
│   on main.tf line 462, in resource "thalassa_vpc_firewall_rule" "mon_to_nodes_nodeexp":
│  462: resource "thalassa_vpc_firewall_rule" "mon_to_nodes_nodeexp" {
│ 
│ The plugin.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│ 
│   with thalassa_vpc_firewall_rule.ksm[0],
│   on main.tf line 478, in resource "thalassa_vpc_firewall_rule" "ksm":
│  478: resource "thalassa_vpc_firewall_rule" "ksm" {
│ 
│ The plugin.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│ 
│   with thalassa_vpc_firewall_rule.loki_from_nodes[0],
│   on main.tf line 494, in resource "thalassa_vpc_firewall_rule" "loki_from_nodes":
│  494: resource "thalassa_vpc_firewall_rule" "loki_from_nodes" {
│ 
│ The plugin.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Plugin did not respond
│ 
│   with thalassa_vpc_firewall_rule.loki_from_db[0],
│   on main.tf line 510, in resource "thalassa_vpc_firewall_rule" "loki_from_db":
│  510: resource "thalassa_vpc_firewall_rule" "loki_from_db" {
│ 
│ The plugin encountered an error, and failed to respond to the plugin.(*GRPCProvider).ReadResource call. The plugin logs may contain more
│ details.
╵
╷
│ Error: Request cancelled
│ 
│   with thalassa_vpc_firewall_rule.kapi[0],
│   on main.tf line 526, in resource "thalassa_vpc_firewall_rule" "kapi":
│  526: resource "thalassa_vpc_firewall_rule" "kapi" {
│ 
│ The plugin.(*GRPCProvider).ReadResource request was cancelled.
╵
╷
│ Error: Request cancelled
│ 
│   with thalassa_vpc_firewall_rule.konn[0],
│   on main.tf line 542, in resource "thalassa_vpc_firewall_rule" "konn":
│  542: resource "thalassa_vpc_firewall_rule" "konn" {
│ 
│ The plugin.(*GRPCProvider).ReadResource request was cancelled.
╵
╷
│ Error: Request cancelled
│ 
│   with thalassa_vpc_firewall_rule.dns[0],
│   on main.tf line 558, in resource "thalassa_vpc_firewall_rule" "dns":
│  558: resource "thalassa_vpc_firewall_rule" "dns" {
│ 
│ The plugin.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│ 
│   with thalassa_vpc_firewall_rule.regall[0],
│   on main.tf line 593, in resource "thalassa_vpc_firewall_rule" "regall":
│  593: resource "thalassa_vpc_firewall_rule" "regall" {
│ 
│ The plugin.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│ 
│   with thalassa_vpc_firewall_rule.mon_egress_any[0],
│   on main.tf line 609, in resource "thalassa_vpc_firewall_rule" "mon_egress_any":
│  609: resource "thalassa_vpc_firewall_rule" "mon_egress_any" {
│ 
│ The plugin.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│ 
│   with thalassa_vpc_firewall_rule.kubelet_cp_to_nodes[0],
│   on main.tf line 633, in resource "thalassa_vpc_firewall_rule" "kubelet_cp_to_nodes":
│  633: resource "thalassa_vpc_firewall_rule" "kubelet_cp_to_nodes" {
│ 
│ The plugin.(*GRPCProvider).ValidateResourceConfig request was cancelled.
╵
╷
│ Error: Request cancelled
│ 
│   with thalassa_vpc_firewall_rule.kubelet_cp_to_db[0],
│   on main.tf line 649, in resource "thalassa_vpc_firewall_rule" "kubelet_cp_to_db":
│  649: resource "thalassa_vpc_firewall_rule" "kubelet_cp_to_db" {
│ 
│ The plugin.(*GRPCProvider).ReadResource request was cancelled.
╵
╷
│ Error: Request cancelled
│ 
│   with thalassa_vpc_firewall_rule.kubelet_cp_to_mon[0],
│   on main.tf line 665, in resource "thalassa_vpc_firewall_rule" "kubelet_cp_to_mon":
│  665: resource "thalassa_vpc_firewall_rule" "kubelet_cp_to_mon" {
│ 
│ The plugin.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵
╷
│ Error: Request cancelled
│ 
│   with thalassa_vpc_firewall_rule.kubelet_mon_to_nodes[0],
│   on main.tf line 686, in resource "thalassa_vpc_firewall_rule" "kubelet_mon_to_nodes":
│  686: resource "thalassa_vpc_firewall_rule" "kubelet_mon_to_nodes" {
│ 
│ The plugin.(*GRPCProvider).UpgradeResourceState request was cancelled.
╵

Stack trace from the terraform-provider-thalassa_v0.16.0 plugin:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x104a9037c]

goroutine 56 [running]:
github.com/thalassa-cloud/terraform-provider-thalassa/thalassa/iaas.resourceSecurityGroupRead({0x104edaab0, 0x14000196af0}, 0x1400079c6c0, {0x104e7eb40?, 0x14000306d80?})
        github.com/thalassa-cloud/terraform-provider-thalassa/thalassa/iaas/resource_security_group.go:267 +0x4ac
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).read(0x140001e5500, {0x104edaa08, 0x140005ccbd0}, 0x1400079c6c0, {0x104e7eb40, 0x14000306d80})
        github.com/hashicorp/terraform-plugin-sdk/v2@v2.38.1/helper/schema/resource.go:866 +0xe4
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).RefreshWithoutUpgrade(0x140001e5500, {0x104edaa08, 0x140005ccbd0}, 0x140001fca90, {0x104e7eb40, 0x14000306d80})
        github.com/hashicorp/terraform-plugin-sdk/v2@v2.38.1/helper/schema/resource.go:1162 +0x400
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).ReadResource(0x1400045a588, {0x104edaa08?, 0x140005cca50?}, 0x140007920f0)
        github.com/hashicorp/terraform-plugin-sdk/v2@v2.38.1/helper/schema/grpc_provider.go:915 +0x9bc
github.com/hashicorp/terraform-plugin-go/tfprotov5/tf5server.(*server).ReadResource(0x14000293a40, {0x104edaa08?, 0x14000754360?}, 0x140002a9340)
        github.com/hashicorp/terraform-plugin-go@v0.29.0/tfprotov5/tf5server/server.go:862 +0x210
github.com/hashicorp/terraform-plugin-go/tfprotov5/internal/tfplugin5._Provider_ReadResource_Handler({0x104eaf7c0, 0x14000293a40}, {0x104edaa08, 0x14000754360}, 0x14000628780, 0x0)
        github.com/hashicorp/terraform-plugin-go@v0.29.0/tfprotov5/internal/tfplugin5/tfplugin5_grpc.pb.go:753 +0x1c0
google.golang.org/grpc.(*Server).processUnaryRPC(0x1400029e200, {0x104edaa08, 0x140007542d0}, 0x14000348600, 0x140003cff20, 0x10552de38, 0x0)
        google.golang.org/grpc@v1.75.1/server.go:1431 +0xc9c
google.golang.org/grpc.(*Server).handleStream(0x1400029e200, {0x104edb1d8, 0x1400037c000}, 0x14000348600)
        google.golang.org/grpc@v1.75.1/server.go:1842 +0x900
google.golang.org/grpc.(*Server).serveStreams.func2.1()
        google.golang.org/grpc@v1.75.1/server.go:1061 +0x84
created by google.golang.org/grpc.(*Server).serveStreams.func2 in goroutine 36
        google.golang.org/grpc@v1.75.1/server.go:1072 +0x138

Error: The terraform-provider-thalassa_v0.16.0 plugin crashed!

This is always indicative of a bug within the plugin. It would be immensely
helpful if you could report the crash with the plugin's maintainers so that it
can be fixed. The output above should help diagnose the issue.